setDefaultNightMode does not update resources nor trigger activity onNightModeChanged in some instances [188681415]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

cf...@coyote-group.com

created issue #1

May 20, 2021 12:34PM

Version used: 1.4.0-alpha01
Devices/Android versions reproduced on: pretty much any device and api (seen on emulators/Huawei/Samsungs, api 27/29/30)

If you have a stack of activities with android:configChanges="uiMode" and you call AppCompatDelegate.setDefaultNightMode it can cause other activities resources (1 or more) not to be updated (and onNightModeChanged not triggered).
It happens when the setDefaultNightMode is called from another thread that the top activity (with a handler Handler(Looper.getMainLooper()).post {} or RX AndroidSchedulers.mainThread().scheduleDirect {})

Eg :
Activity A with uiMode
Activity B with uiMode
Activity C with uiMode

Here is your stack : A > B > C (C on top)
Call AppCompatDelegate.setDefaultNightMode with a new mode on activity C (but not directly from this activity, ex with RX AndroidSchedulers.mainThread or an handler)
Activity C receives the onConfigurationChanged/onNightModeChanged, Activity B receives the onNightModeChanged but one time out of two activity A not receives the onNightModeChanged (and the resources are indeed not updated when back to A).

Process:
A > B > C > setDefaultNightMode OK > go back to A (B & C destroyed) > B > C > setDefaultNightMode KO (wrong configuration for A)
& so on (OK/KO/OK/KO...)

I think the fix for the

issue 169770885

leads to this issue.
Before the fix of the 169770885, i had a different issue (since 1.2.0) (onConfigurationChanged not called on Activity C after setDefaultNightMode)

Technically here is what I have seen :
- The AppCompatDelegate has 3 AppCompatDelegateImpl (for A,B and C) in sActivityDelegates (both when the setDefaultNightMode works well or not)
- When calculating the currentNightMode in AppCompatDelegateImpl.updateForNightMode, the Activity A has the wrong value so the changed is not applied

Regards,

Comments

al...@google.com <al...@google.com> #2May 20, 2021 01:04PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Android build
Which Android build are you using? (e.g. OPP1.170223.012)

Device used
Which device did you use to reproduce this issue?

Steps to reproduce
What steps are needed to reproduce this issue?

Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report capturing
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory. Attach the bug report file to this issue.

Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.

NOTE : To avoid leaking private information, please share screenshots and bugreports only in Google Drive. Share files with android-bugreport@google.com and include only Google drive links in your bug. Bug report attachments should not be included directly in issue reports.

al...@google.com <al...@google.com> #3May 20, 2021 02:01PM

Reassigned to cf...@coyote-group.com.

Can you please address

comment#2

?
Unfortunately the issue would be closed within 7 days if there is no further update.

cf...@coyote-group.com <cf...@coyote-group.com> #4May 20, 2021 02:33PM

Attached is a sample project that demonstrates the issue in two ways:
- when long pressing text (e.g. the headline)
- when opening a select
Both will ultimately load an alert dialog with a list adapter that has the layout ids for the content set to 0.

https://drive.google.com/file/d/1Fe2ym2F0o4XWEDHvKY8-UzpvSJq4wbWq/view?usp=drive_web (WebViewAppCompatBug.zip)

This is reproducible on an API 21 emulator (Nexus 5 configuration, no Chrome installed).

NB There is a second issue when loading the web view in the first place which in this sample project is worked around by using a resource wrapper. This is already reported under

https://issuetracker.google.com/issues/140884278 and the attached project will also display this error when commenting out lines 13-15 in MainActivity.kt.

al...@google.com <al...@google.com> #5May 20, 2021 04:38PM

Please take a look at this issue and provide your inputs.

al...@google.com <al...@google.com> #6May 20, 2021 04:40PM

Wrapping Resources is not supported by the framework and you must not create your own instances of Resources at all (the APIs to do so are now marked deprecated after they were accidentally exposed).

We can't do anything to fix this - you need to solve the underlying problem with appcompat and stop wrapping it like this, and then resources will work.

al...@google.com <al...@google.com> #7May 20, 2021 05:10PM

While I agree this is WontFIx from WebView's perspective (the WebView APK in question already shipped), it seems like this should still be considered a regression from appcompat's perspective, given the community can no longer test on lower-level emulators. We've received several unique user reports of this issue, not to mention the internal reports which led to filing

issue 139710458

.

Surprisingly,

issue 142086375

claims this bug repros on Marshmallow, which is something we haven't observed so far and doesn't fit into the current hypothesis:

> in Android 6.0 (API 23) it crashes on tapping the <select> element.

---

From

issue 141132133

:

> This change is the root cause:

https://android.googlesource.com/platform/frameworks/support/+/26079d87c79a64829f036236353fac1dae4e0613%5E%21/#F2
>
> sAlwaysOverrideConfiguration forces updating the Resources configuration and therby messing up the webview inflation on older devices.

Chis, any chance this checks out? I didn't look too closely into this, so I'm not sure if there are consequences to not overriding the configuration on L-M only, or perhaps further limited old WebView versions only.

al...@google.com <al...@google.com> #8May 20, 2021 05:39PM

Accepted by al...@google.com.

Same problem appear simply by using a WebView on Android 5 / 5.1 (on actual devices, no emulator) with appcompat:1.1.0 directly causing a crash (on display, no interaction needed).

cf...@coyote-group.com <cf...@coyote-group.com> #9May 20, 2021 05:53PM

Dropping the priority of this, since there's no feasible fix for this.

cf...@coyote-group.com <cf...@coyote-group.com> #10May 21, 2021 01:02PM

So, a bug that was laser-focused and easily reproduced by simply including a WebView in an Activity crashing on Android 5 / 5.1 devices with appcompat-1.1.0 but not appcompat-1.1.0-rc01 was marked as duplicate of this, and somehow despite knowing the commit that caused it and being able to reproduce it, and not crashing from Android 5 until that commit it is not feasible to fix. Seems odd to me given the commit seemed to enable a feature, meaning that the choice is crash or have a feature (which you can't use because you crashed). Wouldn't it be better to just not support that feature fully vs crash? Just a thought

TestNightMode.zip

201 KB

Download

cf...@coyote-group.com <cf...@coyote-group.com> #11May 21, 2021 01:08PM

We got this crash on a Samsung Nexus 10 with Android 5.1.1 at 100% on any WebView

al...@google.com <al...@google.com> #12May 21, 2021 05:39PM

Can this be changed back to p2 priority? Phrase "no feasible fix" is not enouth to ignore application crash and make this less importaint

al...@google.com <al...@google.com> #13May 21, 2021 06:01PM

I'm not sure if you can see the duplicate of this ticket. We have lots of tickets which have different causes of the WebView crashes are marked as duplicate with no clarification.

Here is one of them.

https://issuetracker.google.com/issues/141436946

It will be great if you can take some time to revisit duplicate tickets. I believe a lot of developer are looking for the fix or workaround.

Thank you!

al...@google.com <al...@google.com> #14May 21, 2021 06:09PM

Hi, i have same issue in android 22 and 23. Any update?

al...@google.com <al...@google.com> #15May 21, 2021 06:37PM

+1, I'm getting the same issue

al...@google.com <al...@google.com> #16May 21, 2021 06:37PM

I've tried downgrading like you suggested, and it's working for Android 23 but not 22, and the error message changes to:

W/System.err: android.view.WindowManager$BadTokenException: Unable to add window -- token null is not for an application
at android.view.ViewRootImpl.setView(ViewRootImpl.java:566)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:282)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:85)
at android.app.Dialog.show(Dialog.java:298)
at com.android.org.chromium.content.browser.input.SelectPopupDialog.show(SelectPopupDialog.java:133)
at com.android.org.chromium.content.browser.ContentViewCore.showSelectPopup(ContentViewCore.java:2229)
at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

al...@google.com <al...@google.com> #17May 26, 2021 05:58PM

Same issue, SDK 21 with androidx.appcompat 1.1.0

al...@google.com <al...@google.com> #18May 26, 2021 06:07PM

https://issuetracker.google.com/issues/141351441#comment10

ap...@google.com <ap...@google.com> #19May 26, 2021 07:21PM

Marked as fixed.

+1 same here