IssueTracker

I was able to repro in androidx, but creating a repro in metalava doesn't seem to work, so far this is the test I've written

    @Test
    fun `Adding default modifier to a method`() {
        check(
            expectedIssues = "",
            format = FileFormat.V4,
            checkCompatibilityApi = """
                // Signature format: 4.0
                package test.pkg {
                  public interface FirstClass {
                    method public <T extends java.lang.String> T! create(Class<T!>!);
                  }
                  public class SecondClass {
                    ctor public SecondClass();
                    method public <T extends java.lang.String> T! create(Class<T!>!);
                  }
                }
                """,
            sourceFiles = arrayOf(
                java("""
                    package test.pkg;
                    public interface FirstClass {
                        default <T extends String> T create(Class<T> modelClass) {
                            throw new UnsupportedOperationException();
                        }
                    }
                """),
                java("""
                    package test.pkg;
                    public class SecondClass extends FirstClass {
                        @Override
                        public <T extends String> T create(Class<T> modelClass);
                    }
                """)
            )
        )
    }

@sergeyv any idea what I'm missing here?

Is it fine that your source file for SecondClass doesn't contain implementation?

 public class SecondClass extends FirstClass {
     @Override
     public <T extends String> T create(Class<T> modelClass); // implement me?
 }

I tried to go even closer to source for the test, but no luck

    @Test
    fun `Adding default modifier to a method`() {
        check(
            expectedIssues = "",
            format = FileFormat.V4,
            checkCompatibilityApi = """
                // Signature format: 4.0
                package test.pkg {
                  public abstract class ViewModel {
                    ctor public ViewModel();
                  }
                  public class ViewModelProvider {
                    ctor public ViewModelProvider();
                  }
                  public static interface ViewModelProvider.Factory {
                    method public <T extends test.pkg.ViewModel> T! create(Class<T!>!);
                  }
                  public static class ViewModelProvider.NewInstanceFactory implements test.pkg.ViewModelProvider.Factory {
                    ctor public ViewModelProvider.NewInstanceFactory();
                    method public <T extends test.pkg.ViewModel> T! create(Class<T!>!);
                  }
                }
                """,
            sourceFiles = arrayOf(
                java("""
                    package test.pkg;
                    public class ViewModelProvider {
                        public interface Factory {
                            default <T extends ViewModel> T create(Class<T> modelClass) {
                                throw new UnsupportedOperationException();
                            }
                        }
                        
                        public static class NewInstanceFactory implements Factory {
                            @Override
                            public <T extends ViewModel> T create(Class<T> modelClass) {
                                return null;
                            }
                        }
                    }
                """),
                java("""
                    package test.pkg;
                    public abstract class ViewModel {
                    }
                """)
            )
        )
    }

It must have been a bug in old metalava, i'm unable to repro in androidx either now (I reverted 927300ff9fd87da629f28a56058b29750700c845 and ce18bf219466f2453cebb2a20bc4cef23a6a89bd, then changed ViewModelProvider.Factory to default method.