Compose viewModel() doesn't allow you to pass in a ViewModelStoreOwner [188693123]

Fixed

Bug

Status Update

No update yet.

Description

ng...@gmail.com

created issue #1

May 19, 2021 08:18PM

Component used: ViewModel Version used: 2.3.1 Devices/Android versions reproduced on: Emulator API 29

I just want to share a ViewModel object across navigation changes (using Jetpack Compose). I mean, ScreenA is instantiating MyViewModel using viewModel() function. When I navigate (using Jetpack Navigation for Compose) to ScreenB and call viewModel() from there, it returns a different instance.

My current solution is a little ugly...

NavHost(navController = navController, startDestination = ROUTE_WELCOME) {
    ...
    composable(ROUTE_SCREEN_A) {
        ScreenA(
            onNext = { navController.navigate(ROUTE_SCREEN_B) }
        ) // inside of this function, I'm calling viewModel()
    }
    composable(ROUTE_SCREEN_B) {
        // TODO improve this
        val vm = ViewModelProvider(navController.previousBackStackEntry!!)
                .get(MyViewModel::class.java)
        ScreenB(vm)
    }
}

There's no viewModel() method that takes a ViewModelStoreOwner. It just always uses the LocalViewModelStoreOwner.current.

Comments

il...@google.com <il...@google.com> May 19, 2021 08:20PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> May 20, 2021 07:31PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #2Jun 9, 2021 06:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 47fa86ca5165deb3e298bdd8eddd485322a2a043
Author: malkov <malkov@google.com>
Date: Mon Sep 04 18:21:33 2023

Mark some foundation functions and modifiers as @Stable

Relnote: more modifiers marked as stable
Bug: 298046462
Test: updateApi, pure api change
Change-Id: I56af1d5a1f7e93a0e228a57e6631957ff94f82a3

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicTooltip.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/ClipScrollableContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/SelectableGroup.kt

https://android-review.googlesource.com/2738797

il...@google.com <il...@google.com> #3Jun 9, 2021 06:26PM

Marked as fixed.

The only ones left are bring into view and focus related, but they do need some refactoring and modifier.node conversion before that.

Over to Ralston to handle that later.

me...@gmail.com <me...@gmail.com> #4Nov 19, 2021 08:35AM

Necesito que mi celular pase a versión 10, aun no lo actualizan. Gracias

Issue 188693123