Deprecate ID based Kotlin DSL builders in preference for route based builders [188816479]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

May 20, 2021 07:36PM

Component used: Navigation

Version used: 2.4.0-alpha01

With the introduction of routes to the Kotlin DSL builders of NavDestinationBuilder and NavGraphBuilder in Navigation 2.4.0-alpha01, all of the other Kotlin DSL builders should be replaced with ones that take routes. The existing DSLs that take an ID should be deprecated.

Comments

ap...@google.com <ap...@google.com> #2May 25, 2021 07:28PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

jb...@google.com <jb...@google.com> #3May 25, 2021 07:29PM

Marked as fixed.

yea i'll take it.

ap...@google.com <ap...@google.com> #4May 26, 2021 11:27PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Issue 188816479

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 25, 2021 07:28PM

jb...@google.com <jb...@google.com> #3May 25, 2021 07:29PM

ap...@google.com <ap...@google.com> #4May 26, 2021 11:27PM

Add comment

Issue metadata