Deprecate ID based Kotlin DSL builders in preference for route based builders [188816479]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

May 20, 2021 07:36PM

Component used: Navigation

Version used: 2.4.0-alpha01

With the introduction of routes to the Kotlin DSL builders of NavDestinationBuilder and NavGraphBuilder in Navigation 2.4.0-alpha01, all of the other Kotlin DSL builders should be replaced with ones that take routes. The existing DSLs that take an ID should be deprecated.

Comments

ap...@google.com <ap...@google.com> #2May 25, 2021 07:28PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

jb...@google.com <jb...@google.com> #3May 25, 2021 07:29PM

Marked as fixed.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4May 26, 2021 11:27PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

Issue 188816479

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 25, 2021 07:28PM

jb...@google.com <jb...@google.com> #3May 25, 2021 07:29PM

ap...@google.com <ap...@google.com> #4May 26, 2021 11:27PM

Add comment

Issue metadata