2.4.0-alpha01 can't properly navigate to included dynamic graph [188859835]

Fixed

Bug

Status Update

No update yet.

Description

zo...@gmail.com

created issue #1

May 21, 2021 06:22AM

Component used: Navigation Version used: 2.4.0-alpha01 Devices/Android versions reproduced on:

While navigating to a included dynamic graph you need to navigate twice at app startup. So the user would need to click a button twice. But it's not needed for future actions while the app is hot. Feels like it needs that first navigate in order to read the graph so it can navigate later on.

Sample project: https://github.com/davols/navigate-twice-issue

Comments

il...@google.com <il...@google.com> May 21, 2021 08:10PM

Assigned to be...@google.com.

be...@google.com <be...@google.com> May 24, 2021 04:24PM

Accepted by be...@google.com.

be...@google.com <be...@google.com> #2May 24, 2021 10:41PM

since these are in public API (:/) we need to do this in 1.2

be...@google.com <be...@google.com> #3May 26, 2021 09:44PM

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4May 27, 2021 04:42PM

Opening diff shortly

il...@google.com <il...@google.com> #5Jun 1, 2021 08:16PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

Issue 188859835