androidx.navigation:navigation-*:2.4.0-alpha01 crashes with ConcurrentModificationException [188860458]

Fixed

Bug

Status Update

No update yet.

Description

co...@protonmail.com

created issue #1

May 21, 2021 04:22AM

Component used: Navigation Version used: androidx.navigation:navigation-*:2.4.0-alpha01 Devices/Android versions reproduced on:

I don't have a repro project, but I do have a stacktrace:

2021-05-21 00:19:31.604 12663-12663/com.rollertoaster.app E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.rollertoaster.app, PID: 12663
    java.util.ConcurrentModificationException
        at java.util.ArrayList$Itr.next(ArrayList.java:860)
        at androidx.navigation.NavController.dispatchOnDestinationChanged(NavController.kt:703)
        at androidx.navigation.NavController.navigate(NavController.kt:1421)
        at androidx.navigation.NavController.navigate(NavController.kt:1200)
        at androidx.navigation.NavController.navigate(NavController.kt:1128)
        at androidx.navigation.ui.NavigationUI.onNavDestinationSelected(NavigationUI.kt:90)
        at androidx.navigation.ui.NavigationUI$setupWithNavController$3.onNavigationItemSelected(NavigationUI.kt:392)
        at com.google.android.material.navigation.NavigationView$1.onMenuItemSelected(NavigationView.java:217)
        at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:834)
        at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
        at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:985)
        at com.google.android.material.internal.NavigationMenuPresenter$1.onClick(NavigationMenuPresenter.java:416)
        at android.view.View.performClick(View.java:7448)
        at android.view.View.performClickInternal(View.java:7425)
        at android.view.View.access$3600(View.java:810)
        at android.view.View$PerformClick.run(View.java:28305)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Comments

jb...@google.com <jb...@google.com> #2May 21, 2021 03:32PM

Andrey, I haven't changed AnimatedVisibility since alpha01, so I don't expect any behavior change. This looks like it may be an issue with subcompose, could you please take a look?

il...@google.com <il...@google.com> #3May 21, 2021 04:25PM

Assigned to jb...@google.com.

I updated to 1.0.0-alpha09 but still experiencing the same result.

zo...@gmail.com <zo...@gmail.com> #4May 21, 2021 08:44PM

cc+ Matvei for input on Scaffold

ap...@google.com <ap...@google.com> #5May 24, 2021 08:29PM

Hm, interesting, form the quick looks it seems like nothing changed in scaffold in alpha08. The only thing we've done around alpha07 is migrated scaffold to subcompose and it directly affects the padding parameter.

Louis, do you have any ideas is that might've caused the problem?

jb...@google.com <jb...@google.com> #6May 26, 2021 09:03PM

Marked as fixed.

Hm, I can't immediately reproduce with an example locally so not sure what's going on, might be related to how / when subcomposition invalidates

Issue 188860458