androidx.navigation:navigation-*:2.4.0-alpha01 crashes with ConcurrentModificationException [188860458]

Fixed

Bug

Status Update

No update yet.

Description

co...@protonmail.com

created issue #1

May 21, 2021 04:22AM

Component used: Navigation Version used: androidx.navigation:navigation-*:2.4.0-alpha01 Devices/Android versions reproduced on:

I don't have a repro project, but I do have a stacktrace:

2021-05-21 00:19:31.604 12663-12663/com.rollertoaster.app E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.rollertoaster.app, PID: 12663
    java.util.ConcurrentModificationException
        at java.util.ArrayList$Itr.next(ArrayList.java:860)
        at androidx.navigation.NavController.dispatchOnDestinationChanged(NavController.kt:703)
        at androidx.navigation.NavController.navigate(NavController.kt:1421)
        at androidx.navigation.NavController.navigate(NavController.kt:1200)
        at androidx.navigation.NavController.navigate(NavController.kt:1128)
        at androidx.navigation.ui.NavigationUI.onNavDestinationSelected(NavigationUI.kt:90)
        at androidx.navigation.ui.NavigationUI$setupWithNavController$3.onNavigationItemSelected(NavigationUI.kt:392)
        at com.google.android.material.navigation.NavigationView$1.onMenuItemSelected(NavigationView.java:217)
        at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:834)
        at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
        at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:985)
        at com.google.android.material.internal.NavigationMenuPresenter$1.onClick(NavigationMenuPresenter.java:416)
        at android.view.View.performClick(View.java:7448)
        at android.view.View.performClickInternal(View.java:7425)
        at android.view.View.access$3600(View.java:810)
        at android.view.View$PerformClick.run(View.java:28305)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Comments

jb...@google.com <jb...@google.com> #2May 21, 2021 03:32PM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

il...@google.com <il...@google.com> #3May 21, 2021 04:25PM

Assigned to jb...@google.com.

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

zo...@gmail.com <zo...@gmail.com> #4May 21, 2021 08:44PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

ap...@google.com <ap...@google.com> #5May 24, 2021 08:29PM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

jb...@google.com <jb...@google.com> #6May 26, 2021 09:03PM

Marked as fixed.

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Issue 188860458