Add Kotlin DSL builders with routes for Fragment and Activity Kotlin DSL [188914648]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

May 21, 2021 06:17PM

When we introduced the concept of routes in Navigation, we should have also added route options for the fragment and activity builders as well.

Comments

ap...@google.com <ap...@google.com> #2May 21, 2021 08:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0b8a938bdf46865d29a19d33317334693460c27c
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri May 21 11:26:23 2021

Add routes to Fragment and Activity kotlin dsl

Now that routes are supported in Navigation, the Fragment and Activity
destination builders should be updated to take routes as well.

RelNote: "Both the Fragment and Activity destinations builders now
support using routes."
Test: updated all builder tests
Bug: 188914648

Change-Id: Ib5544bd128a17f0dc681e105a1ce4a8a28945bc3

M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/ActivityNavigatorDestinationBuilderTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/ActivityNavigatorDestinationBuilder.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavHost.kt

https://android-review.googlesource.com/1716030

jb...@google.com <jb...@google.com> #3May 24, 2021 07:40PM

Marked as fixed.

This has been added internally and will be available in the Navigation 2.4.0-alpha02 release.

jb...@google.com <jb...@google.com> May 24, 2021 10:11PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #4May 25, 2021 06:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit d53bdfa2add5524b6084f77c4c2abcd60520bf13
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 24 15:19:50 2021

Add routes for Dialog kotlin dsl

Now that routes are supported in Navigation, Dialog destination builders
shiould be updated to take routes.

RelNote: "Dialog destinations now support using routes"
Test: DialogFragmentNavigatorDestination Test
Bug: 188914648
Change-Id: Ia617ba47da5c4995fd21ce2becdf527ac6ade4e9

M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt

https://android-review.googlesource.com/1717111

jb...@google.com <jb...@google.com> May 25, 2021 06:31PM

Marked as fixed.

Issue 188914648