Crash (IndexOutOfBoundsException) on back navigation when using shared element transition with a viewgroup [188969304]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

May 22, 2021 11:00PM

Artifact used androidx.appcompat:appcompat:1.3.0: Version used: 1.3.0 Theme used: Default Devices/Android versions reproduced on: Google Pixel 3XL, Android 11

The code can be found in https://github.com/dmapr/fragment-1.3.4-bug
Screen recordings when building with appcompat-1.3.0 and appcompat-1.2.0 attached

It also appears that on appcompat-1.3.0 only the ViewGroup containing the text is transitioning, the standalone ImageView included in the transition is ignored. The appcompat-1.2.0 transitions both views properly.

05-22 15:51:09.968  7068  7068 E AndroidRuntime: FATAL EXCEPTION: main
05-22 15:51:09.968  7068  7068 E AndroidRuntime: Process: com.rnd8x8.fragment_134_bug, PID: 7068
05-22 15:51:09.968  7068  7068 E AndroidRuntime: java.lang.IndexOutOfBoundsException: Index: 3, Size: 3
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at java.util.ArrayList.get(ArrayList.java:437)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.FragmentTransitionImpl.setNameOverridesReordered(FragmentTransitionImpl.java:183)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.DefaultSpecialEffectsController.startTransitions(DefaultSpecialEffectsController.java:665)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.DefaultSpecialEffectsController.executeOperations(DefaultSpecialEffectsController.java:114)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.SpecialEffectsController.executePendingOperations(SpecialEffectsController.java:294)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.Fragment$3.run(Fragment.java:2780)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:223)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7660)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

shared-element-transition-appcompat-1.2.0.mp4

1.2 MB

Download

shared-element-transition-appcompat-1.3.0.mp4

3.1 MB

Download

Comments

dm...@gmail.com <dm...@gmail.com> #2May 23, 2021 07:22PM

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

ow...@google.com <ow...@google.com> #3May 25, 2021 03:40PM

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

dm...@gmail.com <dm...@gmail.com> #4May 25, 2021 03:57PM

I also can't give parameters to the fragment being inflated.

il...@google.com <il...@google.com> Jun 8, 2021 07:52PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Jun 9, 2021 11:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

jb...@google.com <jb...@google.com> #6Jun 10, 2021 01:51AM

Marked as fixed.

Hey, Thanks to checking this out, I just checked this sample in the the repository, but this does not solve my issue.

I don't have access to the actual fragment class, we use an abstraction that just returns me a instance of Fragment with the arguments set, so this won't solve the issue for me, would it be possible to allow passing the Fragment instance ?

eu...@gmail.com <eu...@gmail.com> #7Sep 1, 2021 09:44AM

Re comment#6 - no. AndroidFragment uses the FragmentFactory you've set on your FragmentManager to instantiate fragment instances, ensuring that every construction of the fragment, from the initial one to the one after process death and recreation all go through the same route.

This aligns with other fragment based APIs like FragmentScenario and NavHostFragment. You'll want to adjust your own abstraction to use those APIs and separate the creation of the fragment instance from the arguments.

dm...@gmail.com <dm...@gmail.com> #8Sep 1, 2021 03:27PM

I'll note that FragmentFactory does allow you to request an AbstractBaseFragment and redirect it to a specific subclass of that class without exposing that subclass itself if you do need that level of indirection.