Crash (IndexOutOfBoundsException) on back navigation when using shared element transition with a viewgroup [188969304]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

May 22, 2021 11:00PM

Artifact used androidx.appcompat:appcompat:1.3.0: Version used: 1.3.0 Theme used: Default Devices/Android versions reproduced on: Google Pixel 3XL, Android 11

The code can be found in https://github.com/dmapr/fragment-1.3.4-bug
Screen recordings when building with appcompat-1.3.0 and appcompat-1.2.0 attached

It also appears that on appcompat-1.3.0 only the ViewGroup containing the text is transitioning, the standalone ImageView included in the transition is ignored. The appcompat-1.2.0 transitions both views properly.

05-22 15:51:09.968  7068  7068 E AndroidRuntime: FATAL EXCEPTION: main
05-22 15:51:09.968  7068  7068 E AndroidRuntime: Process: com.rnd8x8.fragment_134_bug, PID: 7068
05-22 15:51:09.968  7068  7068 E AndroidRuntime: java.lang.IndexOutOfBoundsException: Index: 3, Size: 3
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at java.util.ArrayList.get(ArrayList.java:437)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.FragmentTransitionImpl.setNameOverridesReordered(FragmentTransitionImpl.java:183)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.DefaultSpecialEffectsController.startTransitions(DefaultSpecialEffectsController.java:665)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.DefaultSpecialEffectsController.executeOperations(DefaultSpecialEffectsController.java:114)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.SpecialEffectsController.executePendingOperations(SpecialEffectsController.java:294)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at androidx.fragment.app.Fragment$3.run(Fragment.java:2780)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:223)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7660)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
05-22 15:51:09.968  7068  7068 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

shared-element-transition-appcompat-1.2.0.mp4

1.2 MB

Download

shared-element-transition-appcompat-1.3.0.mp4

3.1 MB

Download

Comments

dm...@gmail.com <dm...@gmail.com> #2May 23, 2021 07:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ow...@google.com <ow...@google.com> #3May 25, 2021 03:40PM

It sounds like this is a behavior change between fragment:1.3.3 and fragment-1.3.4 which bumping appcompat pulls in.

dm...@gmail.com <dm...@gmail.com> #4May 25, 2021 03:57PM

Yes, I'm 99% sure it's a side-effect of this commit: https://android-review.googlesource.com/q/I99675eac030325415789be0762aa666355f27dd8

il...@google.com <il...@google.com> Jun 8, 2021 07:52PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Jun 9, 2021 11:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 06769a572f7003fb662109b595952d6ff5c63a74
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 16:35:28 2021

Fix fragment transitions in new state manager

In aosp/1679887 we attempted to fix doing shared element transitions on
ViewGroups with the transitionGroup="false" attribute set. That change
caused a regression in enter and exit transitions, and could also cause
errors if the entering fragment attempted to transition more views than
the exiting fragment.

This change makes it so that fragments no longer looks at all of the
views in the hierarchy of sharedelement views. We depend on transition
names to determine if a view is a shared element, and if a shared
element is a viewgroup with transitionGroup="true", the entering/exiting
transition should ignore that viewgroup and transition its unnamed
children.

RelNote: "Fixed regression in shared element transtions caused by
aosp/1679887. Setting transitionGroup=\"true\" will now work correctly and
shared elements will no longer throw `IndexOutOfBoundsException`s."
Test: FragmentSharedElementTransitionTest
Bug: 188679569
Bug: 188969304

Change-Id: I164845639cae1f64cf54e4e89b2a24d7eb649beb

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentSharedElementTransitionTest.kt
A fragment/fragment/src/androidTest/res/layout/scene6.xml
A fragment/fragment/src/androidTest/res/layout/scene7.xml
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1732732

jb...@google.com <jb...@google.com> #6Jun 10, 2021 01:51AM

Marked as fixed.

This has been fixed internally and will be part of the Fragment 1.4.0-alpha03 release. You can verify that it works with your app by following the instructions at androidx.dev to enable SNAPSHOTs and using a buildId of 7444280+.

eu...@gmail.com <eu...@gmail.com> #7Sep 1, 2021 09:44AM

would the fix be backported to 1.3.x?

dm...@gmail.com <dm...@gmail.com> #8Sep 1, 2021 03:27PM

The fix has been available since 1.3.5: https://developer.android.com/jetpack/androidx/releases/fragment#1.3.5