Status Update
Comments
il...@google.com <il...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023
Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"
Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
https://android-review.googlesource.com/2886766
Branch: androidx-main
commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023
Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"
Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
Description
androidx.navigation:navigation-fragment-ktx:2.3.5
androidx.navigation:navigation-ui-ktx:2.3.5
when I have two similar bu different Deeplink destinations in a graph like;
app://watch/detail/{reWriteId}
app://watch/{reWriteId}
When I create uri for "app://watch/detail/cartoon"
and create a Deeplink for "app://watch/detail/{reWriteId}" with NavDeepLinkRequest.Builder.fromUri(uri);
I get a best match for "app://watch/{reWriteId}" with argument "detail/cartoon"
but I must get match for "app://watch/detail/{reWriteId}" with argument "cartoon"
When I dig into NavDestination.matchDeepLink, I figured out both regex matches but it keeps first matched one as bestMatch.
I think you are generating wrong regex so there must be no "/" in an argument.
Thanks.