IssueTracker

I'm trying to convert from inline classes to @JvmInline value class. This is supposed to be a binary compatible change, and in fact is supposed to use the same codepath in the IR lowering so in theory the output class files should be roughly identical, and a brief check with javap -private seems to confirm this. However, metalava is complaining bitterly about methods being removed (methods which, as far as I can tell with javap, are still there).

Example (running ./gradlew :compose:runtime:runtime:checkApiRelease --no-daemon fails):

diff --git a/compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt b/compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
index e8ff224e93b..269f5d1f05a 100644
--- a/compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
+++ b/compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
@@ -3024,8 +3024,8 @@ internal class ComposerImpl(
  *
  * @see ComposeNode
  */
-@Suppress("INLINE_CLASS_DEPRECATED", "EXPERIMENTAL_FEATURE_WARNING")
-inline class Updater<T> constructor(
+@JvmInline
+value class Updater<T> constructor(
     @PublishedApi internal val composer: Composer
 ) {
     /**
@@ -3138,8 +3138,8 @@ inline class Updater<T> constructor(
         composer.apply<Unit, T>(Unit, { this.block() })
     }
 }
-@Suppress("INLINE_CLASS_DEPRECATED", "EXPERIMENTAL_FEATURE_WARNING")
-inline class SkippableUpdater<T> constructor(
+@JvmInline
+value class SkippableUpdater<T> constructor(
     @PublishedApi internal val composer: Composer
 ) {
     inline fun update(block: Updater<T>.() -> Unit) {

And run ./gradlew :compose:runtime:runtime:checkApiRelease --no-daemon to see the errors.

It gives errors like:

/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:347: error: Removed constructor androidx.compose.runtime.SkippableUpdater() [RemovedMethod]
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:348: error: Removed method androidx.compose.runtime.SkippableUpdater.constructor-impl(androidx.compose.runtime.Composer) [RemovedMethod]DLE
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:349: error: Removed method androidx.compose.runtime.SkippableUpdater.equals-impl(androidx.compose.runtime.Composer,Object) [RemovedMethod]E
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:350: error: Removed method androidx.compose.runtime.SkippableUpdater.equals-impl0(androidx.compose.runtime.Composer,androidx.compose.runtime.Composer) [RemovedMethod]
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:351: error: Removed method androidx.compose.runtime.SkippableUpdater.hashCode-impl(androidx.compose.runtime.Composer) [RemovedMethod
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:352: error: Removed method androidx.compose.runtime.SkippableUpdater.toString-impl(androidx.compose.runtime.Composer) [RemovedMethod
/Users/jsproch/androidx-main/frameworks/support/compose/runtime/runtime/api/1.0.0-beta07.txt:353: error: Removed method androidx.compose.runtime.SkippableUpdater.update-impl(androidx.compose.runtime.Composer,kotlin.jvm.functions.Function1<? super androidx.compose.runtime.Updater<T>,kotlin.Unit>) [RemovedMethod]

But the class files (javap -private) look like this:

public final class androidx.compose.runtime.SkippableUpdater<T> {
  private final androidx.compose.runtime.Composer composer;
  public static void getComposer$annotations();
  public static final void update-impl(androidx.compose.runtime.Composer, kotlin.jvm.functions.Function1<? super androidx.compose.runtime.Updater<T>, kotlin.Unit>);
  public static java.lang.String toString-impl(androidx.compose.runtime.Composer);
  public java.lang.String toString();
  public static int hashCode-impl(androidx.compose.runtime.Composer);
  public int hashCode();
  public static boolean equals-impl(androidx.compose.runtime.Composer, java.lang.Object);
  public boolean equals(java.lang.Object);
  private androidx.compose.runtime.SkippableUpdater(androidx.compose.runtime.Composer);
  public static <T> androidx.compose.runtime.Composer constructor-impl(androidx.compose.runtime.Composer);
  public static final androidx.compose.runtime.SkippableUpdater box-impl(androidx.compose.runtime.Composer);
  public final androidx.compose.runtime.Composer unbox-impl();
  public static final boolean equals-impl0(androidx.compose.runtime.Composer, androidx.compose.runtime.Composer);
}