keyListener cannot be null in EditText in implementation 'androidx.appcompat:appcompat:1.4.0-alpha01' [189559345]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

jp...@gmail.com

created issue #1

May 29, 2021 08:53PM

Hello,

I updated this library

implementation 'androidx.appcompat:appcompat:1.3.0-rc01'

to this

implementation 'androidx.appcompat:appcompat:1.4.0-alpha01'

And there is a bug that started to appear in my code. The bug is:

 java.lang.NullPointerException: keyListener cannot be null
        at androidx.core.util.Preconditions.checkNotNull(Preconditions.java:136)
        at androidx.emoji2.viewshelper.EmojiEditTextHelper.getKeyListener(EmojiEditTextHelper.java:154)
        at androidx.appcompat.widget.AppCompatEmojiEditTextHelper.getKeyListener(AppCompatEmojiEditTextHelper.java:116)
        at androidx.appcompat.widget.AppCompatEditText.setKeyListener(AppCompatEditText.java:342)
        at com.mlt.controls.edit.EditFieldsGenerator.initChooser(EditFieldsGenerator.kt:158)
        at com.mlt.activities.items.controls.ItemRecordEditControl.initChoosers(ItemRecordEditControl.kt:219)
        at com.mlt.activities.items.controls.ItemRecordEditControl.<init>(ItemRecordEditControl.kt:58)
        at com.mlt.activities.items.AddEditItemActivity.addItemRecord(AddEditItemActivity.kt:343)
        at com.mlt.activities.items.AddEditItemActivity.addNewItemRecord(AddEditItemActivity.kt:339)
        at com.mlt.activities.items.AddEditItemActivity$addEventHandlers$2.onClick(AddEditItemActivity.kt:326)
        at android.view.View.performClick(View.java:7300)
        at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:1119)
        at android.view.View.performClickInternal(View.java:7277)
        at android.view.View.access$3600(View.java:822)
        at android.view.View$PerformClick.run(View.java:28033)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:224)
        at android.app.ActivityThread.main(ActivityThread.java:7565)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

This is my code

fun initChooser(textField: TextInputLayout, onClick: () -> Unit, onClear: (() -> Unit)? = null) {  
    // https://stackoverflow.com/questions/60710536/android-using-materialdatepicker-and-textinputlayout  
    textField.editText?.setKeyListener(null)  
    textField.editText?.setInputType(InputType.TYPE_NULL);  
  
    textField.editText?.setOnTouchListener(View.OnTouchListener { v, event ->  
  if (MotionEvent.ACTION_UP == event.action) onClick() // Instead of your Toast  
  false  
  })  
  
    textField.setEndIconOnClickListener {  
  onClear?.invoke()  
    }  
}

The problematic line is textField.editText?.setKeyListener(null) but I do it on purpose since I read on the stackOverflow that keaybord wont' show up after clicking. I want to use it as a read only, and when clicked to open dialog with options to choose from, therefore no keyborad. The stack overflow = https://stackoverflow.com/questions/60710536/android-using-materialdatepicker-and-textinputlayout

So probably I'm not the only one using it this way.

My xml behind this code:

<com.google.android.material.textfield.TextInputLayout  
  android:id="@+id/locationTextField"  
  style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox"  
  android:layout_width="match_parent"  
  android:layout_height="wrap_content"  
  app:endIconMode="clear_text"  
  app:errorEnabled="true"  
  app:helperTextEnabled="true"  
  app:localizeText="@{`Location`}"  
  tools:hint="Location">  
  
    <com.google.android.material.textfield.TextInputEditText  
  android:layout_width="match_parent"  
  android:layout_height="wrap_content"  
  tools:text="Location 11" />  
</com.google.android.material.textfield.TextInputLayout>

I believe it has something to do with some emoji or something, which I do not want to use.

Thank you

Comments

al...@google.com <al...@google.com> Jun 1, 2021 01:58PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Jun 4, 2021 12:02AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

se...@google.com <se...@google.com> Jun 17, 2021 04:36PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #3Jun 18, 2021 06:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit b87de5d5b7159d1d4ff4f81f362880e82e839ce3
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jun 17 11:37:55 2021

Allow nullable KeyListener in AppCompatEditText

This reverses the non-null requirement added by Emoji2 integration.

Bug:

b/189559345

Test: New unit tests
Relnote: "Allow null KeyListener in AppCompatEditText. This reverses the
non-null annotation that was added to AppCompatEditText in 1.4-alpha01
and restores the previous behavior when passed null."

Change-Id: I214824131c0206349b73471a8c22be38bf5dd0d8

M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEditText.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
M emoji2/emoji2-views-helper/api/current.txt
M emoji2/emoji2-views-helper/api/public_plus_experimental_current.txt
M emoji2/emoji2-views-helper/api/restricted_current.txt
M emoji2/emoji2-views-helper/src/androidTest/java/androidx/emoji2/viewsintegration/EmojiEditTextHelperTest.java
M emoji2/emoji2-views-helper/src/main/java/androidx/emoji2/viewsintegration/EmojiEditTextHelper.java

https://android-review.googlesource.com/1739499

se...@google.com <se...@google.com> Jun 22, 2021 07:34PM

Marked as fixed.

sa...@gmail.com <sa...@gmail.com> #4Sep 18, 2021 03:32AM

http://aminoapps.com/invite/9WYDPBGL98

Issue 189559345