Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 47fa86ca5165deb3e298bdd8eddd485322a2a043
Author: malkov <malkov@google.com>
Date: Mon Sep 04 18:21:33 2023
Mark some foundation functions and modifiers as @Stable
Relnote: more modifiers marked as stable
Bug: 298046462
Test: updateApi, pure api change
Change-Id: I56af1d5a1f7e93a0e228a57e6631957ff94f82a3
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicTooltip.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/ClipScrollableContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/SelectableGroup.kt
https://android-review.googlesource.com/2738797
Branch: androidx-main
commit 47fa86ca5165deb3e298bdd8eddd485322a2a043
Author: malkov <malkov@google.com>
Date: Mon Sep 04 18:21:33 2023
Mark some foundation functions and modifiers as @Stable
Relnote: more modifiers marked as stable
Bug: 298046462
Test: updateApi, pure api change
Change-Id: I56af1d5a1f7e93a0e228a57e6631957ff94f82a3
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicTooltip.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/ClipScrollableContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/SelectableGroup.kt
il...@google.com
The only ones left are bring into view and focus related, but they do need some refactoring and modifier.node conversion before that.
Over to Ralston to handle that later.
Description
Summary:
The Up button is displayed on the action bar for root destinations.
Library:
AndroidX Navigation 2.4.0-alpha01
Description:
When using the AndroidX navigation version 2.4.0-alpha01 with the navigation view (to enable support for multiple backstacks, one per each root destination), the app bar shows the Up button for the root destinations. The expectation is that root destinations would not show the Up button.
This issue is a regression from converting class ActionBarOnDestinationChangedListener from Java to Kotlin in this commit:
the method setDisplayHomeAsUpEnabled should be called with FALSE when the icon is null.
This can be reproduced by using the navigation advanced sample from the architecture components, available here: