Fixed
Status Update
Comments
je...@google.com <je...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 4f234ef606e3d27f95a89dfcc1725fa5d6ffa89a
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jun 02 18:59:04 2021
Clean up foundation/ScrollTest
Remove usages of runBlocking* and replace them with better alternatives.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: I9065e0e48fc539c0df31a0062abe2b6008a304e2
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
https://android-review.googlesource.com/1725470
Branch: androidx-main
commit 4f234ef606e3d27f95a89dfcc1725fa5d6ffa89a
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jun 02 18:59:04 2021
Clean up foundation/ScrollTest
Remove usages of runBlocking* and replace them with better alternatives.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: I9065e0e48fc539c0df31a0062abe2b6008a304e2
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 318bf674b2754c7ac5a06e5e4ef3d98f17ce3242
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 17:54:28 2021
Remove ManualFrameClock from public API
The purpose of ManualFrameClock was to be able to control animations by
controlling the clock on which they run. We now have a better tool,
composeTestRule.mainClock, and ManualFrameClock is almost entirely
unused. It is therefore better to remove this from public API.
Bug: 190198467
Bug: 189951065
Test: ./gradlew bOS
Relnote: "Removed `ManualFrameClock`. If you need to control animations,
use `composeTestRule.mainClock` instead."
Change-Id: I3c3e8d0387c37ab3f3a29b648429056ac0eb6b26
M compose/animation/animation-core/api/1.0.0-beta09.txt
M compose/animation/animation-core/api/current.ignore
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_1.0.0-beta09.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_1.0.0-beta09.txt
M compose/animation/animation-core/api/restricted_current.ignore
M compose/animation/animation-core/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/ManualFrameClock.kt
https://android-review.googlesource.com/1728177
Branch: androidx-main
commit 318bf674b2754c7ac5a06e5e4ef3d98f17ce3242
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 17:54:28 2021
Remove ManualFrameClock from public API
The purpose of ManualFrameClock was to be able to control animations by
controlling the clock on which they run. We now have a better tool,
composeTestRule.mainClock, and ManualFrameClock is almost entirely
unused. It is therefore better to remove this from public API.
Bug: 190198467
Bug: 189951065
Test: ./gradlew bOS
Relnote: "Removed `ManualFrameClock`. If you need to control animations,
use `composeTestRule.mainClock` instead."
Change-Id: I3c3e8d0387c37ab3f3a29b648429056ac0eb6b26
M compose/animation/animation-core/api/1.0.0-beta09.txt
M compose/animation/animation-core/api/current.ignore
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_1.0.0-beta09.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_1.0.0-beta09.txt
M compose/animation/animation-core/api/restricted_current.ignore
M compose/animation/animation-core/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/ManualFrameClock.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 5287b1f408a2d2bb39f6284b7a080453b5809fff
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 15:06:43 2021
Clean up foundation/ScrollableTest
Remove usages of AutoTestFrameClock, runBlockingWithManualClock and
runBlocking when there is a better alternative available.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Iacebffbcb8ae37a7172d2b8b76ec55ac52fed951
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
https://android-review.googlesource.com/1728171
Branch: androidx-main
commit 5287b1f408a2d2bb39f6284b7a080453b5809fff
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 15:06:43 2021
Clean up foundation/ScrollableTest
Remove usages of AutoTestFrameClock, runBlockingWithManualClock and
runBlocking when there is a better alternative available.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Iacebffbcb8ae37a7172d2b8b76ec55ac52fed951
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit ff231ccd24f652926de6ababe6bf2384bfecd699
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 16:48:45 2021
Remove obsolete ExperimentalTestApi OptIns
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cDATK
Change-Id: I880f2cd3ceb0d6ea6249c2310ac8e337e66b05e3
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
https://android-review.googlesource.com/1729251
Branch: androidx-main
commit ff231ccd24f652926de6ababe6bf2384bfecd699
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 16:48:45 2021
Remove obsolete ExperimentalTestApi OptIns
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cDATK
Change-Id: I880f2cd3ceb0d6ea6249c2310ac8e337e66b05e3
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 425bed504bda3a9626508f7dfbd8e90ad31815a3
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:48:11 2021
Update isAnimationRunningUpdate test
The test was once written for isAnimationRunning, but that property is
now replaced by isScrollInProgress which has different semantics. In
particular, where `isAnimationRunning` used to be false during a drag,
`isScrollInProgress` is true during a drag.
The actual purpose of the test was to make sure that a fling animation
is interrupted when you put your finger down, so I renamed the method to
reflect this and adjusted the test so it fails if the interrupt doesn't
work properly.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Ide714890c456d23d2748f70e6fc18e7382e415eb
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
https://android-review.googlesource.com/1729252
Branch: androidx-main
commit 425bed504bda3a9626508f7dfbd8e90ad31815a3
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:48:11 2021
Update isAnimationRunningUpdate test
The test was once written for isAnimationRunning, but that property is
now replaced by isScrollInProgress which has different semantics. In
particular, where `isAnimationRunning` used to be false during a drag,
`isScrollInProgress` is true during a drag.
The actual purpose of the test was to make sure that a fling animation
is interrupted when you put your finger down, so I renamed the method to
reflect this and adjusted the test so it fails if the interrupt doesn't
work properly.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Ide714890c456d23d2748f70e6fc18e7382e415eb
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit aa432ce372d0ad04bfc7e32ebd4bf89385d1c11f
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:52:19 2021
Remove last usages of AnimationClocks.kt
Bug: 189951065
Test: ./gradlew bOS
Change-Id: I40ea2455585fa137e586f3db19c848b966c3f905
D compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M hilt/hilt-navigation-compose/src/androidTest/java/androidx/hilt/navigation/compose/HiltViewModelComposeTest.kt
https://android-review.googlesource.com/1729253
Branch: androidx-main
commit aa432ce372d0ad04bfc7e32ebd4bf89385d1c11f
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:52:19 2021
Remove last usages of AnimationClocks.kt
Bug: 189951065
Test: ./gradlew bOS
Change-Id: I40ea2455585fa137e586f3db19c848b966c3f905
D compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M hilt/hilt-navigation-compose/src/androidTest/java/androidx/hilt/navigation/compose/HiltViewModelComposeTest.kt
Description
The tool was written when proper tools for the intended use were not yet available. We're now able to control and advance the mainClock manually, which is a far better solution than introducing a new clock.