Fixed
Status Update
No update yet.
Comments
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
https://android-review.googlesource.com/1360099
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 318bf674b2754c7ac5a06e5e4ef3d98f17ce3242
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 17:54:28 2021
Remove ManualFrameClock from public API
The purpose of ManualFrameClock was to be able to control animations by
controlling the clock on which they run. We now have a better tool,
composeTestRule.mainClock, and ManualFrameClock is almost entirely
unused. It is therefore better to remove this from public API.
Bug: 190198467
Bug: 189951065
Test: ./gradlew bOS
Relnote: "Removed `ManualFrameClock`. If you need to control animations,
use `composeTestRule.mainClock` instead."
Change-Id: I3c3e8d0387c37ab3f3a29b648429056ac0eb6b26
M compose/animation/animation-core/api/1.0.0-beta09.txt
M compose/animation/animation-core/api/current.ignore
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_1.0.0-beta09.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_1.0.0-beta09.txt
M compose/animation/animation-core/api/restricted_current.ignore
M compose/animation/animation-core/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/ManualFrameClock.kt
https://android-review.googlesource.com/1728177
Branch: androidx-main
commit 318bf674b2754c7ac5a06e5e4ef3d98f17ce3242
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 17:54:28 2021
Remove ManualFrameClock from public API
The purpose of ManualFrameClock was to be able to control animations by
controlling the clock on which they run. We now have a better tool,
composeTestRule.mainClock, and ManualFrameClock is almost entirely
unused. It is therefore better to remove this from public API.
Bug: 190198467
Bug: 189951065
Test: ./gradlew bOS
Relnote: "Removed `ManualFrameClock`. If you need to control animations,
use `composeTestRule.mainClock` instead."
Change-Id: I3c3e8d0387c37ab3f3a29b648429056ac0eb6b26
M compose/animation/animation-core/api/1.0.0-beta09.txt
M compose/animation/animation-core/api/current.ignore
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_1.0.0-beta09.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_1.0.0-beta09.txt
M compose/animation/animation-core/api/restricted_current.ignore
M compose/animation/animation-core/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/ManualFrameClock.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5287b1f408a2d2bb39f6284b7a080453b5809fff
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 15:06:43 2021
Clean up foundation/ScrollableTest
Remove usages of AutoTestFrameClock, runBlockingWithManualClock and
runBlocking when there is a better alternative available.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Iacebffbcb8ae37a7172d2b8b76ec55ac52fed951
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
https://android-review.googlesource.com/1728171
Branch: androidx-main
commit 5287b1f408a2d2bb39f6284b7a080453b5809fff
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jun 04 15:06:43 2021
Clean up foundation/ScrollableTest
Remove usages of AutoTestFrameClock, runBlockingWithManualClock and
runBlocking when there is a better alternative available.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Iacebffbcb8ae37a7172d2b8b76ec55ac52fed951
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ff231ccd24f652926de6ababe6bf2384bfecd699
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 16:48:45 2021
Remove obsolete ExperimentalTestApi OptIns
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cDATK
Change-Id: I880f2cd3ceb0d6ea6249c2310ac8e337e66b05e3
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
https://android-review.googlesource.com/1729251
Branch: androidx-main
commit ff231ccd24f652926de6ababe6bf2384bfecd699
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 16:48:45 2021
Remove obsolete ExperimentalTestApi OptIns
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cDATK
Change-Id: I880f2cd3ceb0d6ea6249c2310ac8e337e66b05e3
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 425bed504bda3a9626508f7dfbd8e90ad31815a3
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:48:11 2021
Update isAnimationRunningUpdate test
The test was once written for isAnimationRunning, but that property is
now replaced by isScrollInProgress which has different semantics. In
particular, where `isAnimationRunning` used to be false during a drag,
`isScrollInProgress` is true during a drag.
The actual purpose of the test was to make sure that a fling animation
is interrupted when you put your finger down, so I renamed the method to
reflect this and adjusted the test so it fails if the interrupt doesn't
work properly.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Ide714890c456d23d2748f70e6fc18e7382e415eb
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
https://android-review.googlesource.com/1729252
Branch: androidx-main
commit 425bed504bda3a9626508f7dfbd8e90ad31815a3
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:48:11 2021
Update isAnimationRunningUpdate test
The test was once written for isAnimationRunning, but that property is
now replaced by isScrollInProgress which has different semantics. In
particular, where `isAnimationRunning` used to be false during a drag,
`isScrollInProgress` is true during a drag.
The actual purpose of the test was to make sure that a fling animation
is interrupted when you put your finger down, so I renamed the method to
reflect this and adjusted the test so it fails if the interrupt doesn't
work properly.
Bug: 189951065
Test: ./gradlew compose:foundation:foundation:cC
Change-Id: Ide714890c456d23d2748f70e6fc18e7382e415eb
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit aa432ce372d0ad04bfc7e32ebd4bf89385d1c11f
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:52:19 2021
Remove last usages of AnimationClocks.kt
Bug: 189951065
Test: ./gradlew bOS
Change-Id: I40ea2455585fa137e586f3db19c848b966c3f905
D compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M hilt/hilt-navigation-compose/src/androidTest/java/androidx/hilt/navigation/compose/HiltViewModelComposeTest.kt
https://android-review.googlesource.com/1729253
Branch: androidx-main
commit aa432ce372d0ad04bfc7e32ebd4bf89385d1c11f
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jun 07 17:52:19 2021
Remove last usages of AnimationClocks.kt
Bug: 189951065
Test: ./gradlew bOS
Change-Id: I40ea2455585fa137e586f3db19c848b966c3f905
D compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M hilt/hilt-navigation-compose/src/androidTest/java/androidx/hilt/navigation/compose/HiltViewModelComposeTest.kt
Description
The tool was written when proper tools for the intended use were not yet available. We're now able to control and advance the mainClock manually, which is a far better solution than introducing a new clock.