Status Update
Comments
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
b9...@gmail.com <b9...@gmail.com> #3
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
ok...@gmail.com <ok...@gmail.com> #4
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Branch: androidx-main
commit b31c2a8165f49cd95b53d802dbe13100df8feb1f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 22:00:18 2021
Get applicationId using reflection
Using safe args with dynamic feature modules with AGP 7.0+ currently
crashes saying that DynamicFeatureVariant does not have the
applicationId property. It does have the property, but in 7.0+ it is
part of the GeneratesApk interface that DynamicFeatureVariant
implements and the build cannot resolve that DynamicFeatureVariant has
that method.
We need to use reflection to call the property dynamically instead.
RelNote: "Safe-args no longer crashes when using it with dynamic feature
modules and AGP 7.0+."
Test: tested with sample apps
Bug: 189966576
Change-Id: I6951812da260e739a2d515fb9b3782b90c75642d
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
jb...@google.com <jb...@google.com> #7
This has been fixed internally and will be part of the Navigation 2.4.0-alpha03
release. You can verify that it works with your app by following the instructions at SNAPSHOT
s and using a buildId of 7441181
+.
lc...@gmail.com <lc...@gmail.com> #8
@#7 just to inform if you did not already know, the SNAPSHOT safe args with this fix will not work with gradle 6.8.3, i am getting
Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at
* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
with gradle 6.8.3, while on gadle 7.0 will work.
lc...@gmail.com <lc...@gmail.com> #9
sorry forgot to include the snapshot artifact repo build id. its 7441661
jb...@google.com <jb...@google.com> #10
That is separate from this issue. Please file a new bug with a project that reproduces the problem.
Description
Component used: Navigation Version used:2.4.0-alpha02
I can't apply
"androidx.navigation.safeargs.kotlin"
to dynamic feature module