Fixed
Status Update
No update yet.
Comments
il...@google.com
since these are in public API (:/) we need to do this in 1.2
b9...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
ok...@gmail.com
Opening diff shortly
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b31c2a8165f49cd95b53d802dbe13100df8feb1f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 22:00:18 2021
Get applicationId using reflection
Using safe args with dynamic feature modules with AGP 7.0+ currently
crashes saying that DynamicFeatureVariant does not have the
applicationId property. It does have the property, but in 7.0+ it is
part of the GeneratesApk interface that DynamicFeatureVariant
implements and the build cannot resolve that DynamicFeatureVariant has
that method.
We need to use reflection to call the property dynamically instead.
RelNote: "Safe-args no longer crashes when using it with dynamic feature
modules and AGP 7.0+."
Test: tested with sample apps
Bug: 189966576
Change-Id: I6951812da260e739a2d515fb9b3782b90c75642d
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1728610
Branch: androidx-main
commit b31c2a8165f49cd95b53d802dbe13100df8feb1f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 22:00:18 2021
Get applicationId using reflection
Using safe args with dynamic feature modules with AGP 7.0+ currently
crashes saying that DynamicFeatureVariant does not have the
applicationId property. It does have the property, but in 7.0+ it is
part of the GeneratesApk interface that DynamicFeatureVariant
implements and the build cannot resolve that DynamicFeatureVariant has
that method.
We need to use reflection to call the property dynamically instead.
RelNote: "Safe-args no longer crashes when using it with dynamic feature
modules and AGP 7.0+."
Test: tested with sample apps
Bug: 189966576
Change-Id: I6951812da260e739a2d515fb9b3782b90c75642d
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
jb...@google.com
This has been fixed internally and will be part of the Navigation 2.4.0-alpha03 release. You can verify that it works with your app by following the instructions at SNAPSHOTs and using a buildId of 7441181+.
lc...@gmail.com
@#7 just to inform if you did not already know, the SNAPSHOT safe args with this fix will not work with gradle 6.8.3, i am getting
Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at
* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
with gradle 6.8.3, while on gadle 7.0 will work.
lc...@gmail.com
sorry forgot to include the snapshot artifact repo build id. its 7441661
jb...@google.com
That is separate from this issue. Please file a new bug with a project that reproduces the problem.
Description
Component used: Navigation Version used:2.4.0-alpha02
I can't apply
"androidx.navigation.safeargs.kotlin"to dynamic feature module