Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
b9...@gmail.com
ok...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit fb8f1046e9c417250bc9190d45eab77d34f246d2
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jun 02 17:12:12 2021
Update the ArgumentGenerateTask for safe-args
Updating the safe-args plugin task to be cacheable. That includes making
all of the properties initialized lazily and adjusting the plugin
appropriately.
Test: existing tests pass
Bug: 189966576
Change-Id: I4ff31c2fb3049f7900bb96facc3bf6047c6e1473
M buildSrc/src/main/kotlin/androidx/build/SdkResourceGenerator.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1726191
Branch: androidx-main
commit fb8f1046e9c417250bc9190d45eab77d34f246d2
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jun 02 17:12:12 2021
Update the ArgumentGenerateTask for safe-args
Updating the safe-args plugin task to be cacheable. That includes making
all of the properties initialized lazily and adjusting the plugin
appropriately.
Test: existing tests pass
Bug: 189966576
Change-Id: I4ff31c2fb3049f7900bb96facc3bf6047c6e1473
M buildSrc/src/main/kotlin/androidx/build/SdkResourceGenerator.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b31c2a8165f49cd95b53d802dbe13100df8feb1f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 22:00:18 2021
Get applicationId using reflection
Using safe args with dynamic feature modules with AGP 7.0+ currently
crashes saying that DynamicFeatureVariant does not have the
applicationId property. It does have the property, but in 7.0+ it is
part of the GeneratesApk interface that DynamicFeatureVariant
implements and the build cannot resolve that DynamicFeatureVariant has
that method.
We need to use reflection to call the property dynamically instead.
RelNote: "Safe-args no longer crashes when using it with dynamic feature
modules and AGP 7.0+."
Test: tested with sample apps
Bug: 189966576
Change-Id: I6951812da260e739a2d515fb9b3782b90c75642d
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1728610
Branch: androidx-main
commit b31c2a8165f49cd95b53d802dbe13100df8feb1f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 22:00:18 2021
Get applicationId using reflection
Using safe args with dynamic feature modules with AGP 7.0+ currently
crashes saying that DynamicFeatureVariant does not have the
applicationId property. It does have the property, but in 7.0+ it is
part of the GeneratesApk interface that DynamicFeatureVariant
implements and the build cannot resolve that DynamicFeatureVariant has
that method.
We need to use reflection to call the property dynamically instead.
RelNote: "Safe-args no longer crashes when using it with dynamic feature
modules and AGP 7.0+."
Test: tested with sample apps
Bug: 189966576
Change-Id: I6951812da260e739a2d515fb9b3782b90c75642d
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
jb...@google.com
This has been fixed internally and will be part of the Navigation 2.4.0-alpha03 release. You can verify that it works with your app by following the instructions at SNAPSHOTs and using a buildId of 7441181+.
lc...@gmail.com
@#7 just to inform if you did not already know, the SNAPSHOT safe args with this fix will not work with gradle 6.8.3, i am getting
Unable to find method ''java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)''
'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
at
* What went wrong:
Execution failed for task ':app:generateSafeArgsDebug'.
> 'java.lang.String kotlin.text.CharsKt.titlecase(char, java.util.Locale)'
with gradle 6.8.3, while on gadle 7.0 will work.
lc...@gmail.com
sorry forgot to include the snapshot artifact repo build id. its 7441661
jb...@google.com
That is separate from this issue. Please file a new bug with a project that reproduces the problem.
Description
Component used: Navigation Version used:2.4.0-alpha02
I can't apply
"androidx.navigation.safeargs.kotlin"to dynamic feature module