IssueTracker

Component used: Navigation Safe Args Kotlin Plugin

Version used: 2.4.0-alpha02, AGP 4.2.0-beta03

After upgrading to Navigation 2.4.0-alpha02 and building a minified version of my app, my app crashed with an exception that said that the fromBundle method couldn't be found.

I use the by navArgs() extension, which uses reflection to access this method, so I depended on Navigation's included ProGuard keep rules to properly keep that method.

I found that I could work around this issue via this commit:

# Workaround for Kotlin Safe Args issue
-if public class ** implements androidx.navigation.NavArgs
-keepclassmembers public class <1> {
    public static ** Companion;
    ** fromBundle(android.os.Bundle);
}

Essentially just making sure that the Companion class is kept. After adding that ProGuard rule, the fromBundle() class was successfully kept. I'm not sure why that helped, since I'm pretty sure that the format of the fromBundle() didn't change since Navigation 2.3.5?

Reproduction steps:

1. Check out Muzei
2. Revert this commit
3. Add minifyEnabled true to the debug configuration
4. Run ./gradlew assembleDebug and analyze the resulting APK to verify that the ChooseProviderFragmentArgs.fromBundle() method exists (it won't) 4a) Alternatively, install Muzei, Activate it as your wallpaper, then select the 'Sources' screen. Muzei should not crash.