OnDestinationChangedListener won't get called if it navigates somewhere in response to current destination. [190228815]

Fixed

Bug

Status Update

No update yet.

Description

sh...@google.com

created issue #1

Jun 4, 2021 10:40PM

Component used: Navigation Version used: 2.3.5 Devices/Android versions reproduced on: Irrelevant ;)

Repro steps:

In a OnDestinationChangedListener, set things up so that if the new destination is A, nav to B.
Set the current destination to A.
Add the OnDestinationChangedListener to the NavController.

Expected Result: OnDestinationChangedListener receives callback when it is set, and then receives a callback when it causes navigation to B.

Actual Result: OnDestinationChangedListener receives callback when it is set, and then DOES NOT receive a callback when it causes navigation to B.

After the OnDestinationChangedListener is set, this sort of reentrant call works as would be expected, but when getting the callback after having set the OnDestinationChangedListener, it does not.

I think this simply requires swapping

mOnDestinationChangedListeners.add(listener);

and

if (!mBackStack.isEmpty()) {
            NavBackStackEntry backStackEntry = mBackStack.peekLast();
            listener.onDestinationChanged(this, backStackEntry.getDestination(),
                    backStackEntry.getArguments());
        }

in NavController.java. :)

Comments

il...@google.com <il...@google.com> #2Jun 4, 2021 10:57PM

We also need documentation with a few examples for it.

il...@google.com <il...@google.com> Jun 8, 2021 07:26PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Jun 9, 2021 12:00AM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Jun 9, 2021 03:05AM

Any progress with the documentation?

il...@google.com <il...@google.com> #4Jun 9, 2021 03:42AM

Marked as fixed.

Changelists related to this issue will be linked once they are submitted.

sh...@google.com <sh...@google.com> #5Jun 11, 2021 05:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc23f5c30d0394593e16a594c1502059f7e11140
Author: Ben Weiss <benweiss@google.com>
Date: Mon Mar 09 13:08:13 2020

Kotlin DSL for navigation-dynamic-features-*

Test: check & connectedCheck of affected modules

Bug: 148969800

Change-Id: Icd0cb16fbe7035aca6638c5fb984f27b6eb1ee0c

M navigation/navigation-dynamic-features-fragment/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/AndroidManifest.xml
A navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilder.kt
M navigation/navigation-dynamic-features-runtime/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/current.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_current.txt
A navigation/navigation-dynamic-features-runtime/src/androidTest/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
A navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilder.kt

https://android-review.googlesource.com/1253672

Issue 190228815