IssueTracker

Component used: Navigation Version used: 2.3.5 Devices/Android versions reproduced on: Irrelevant ;)

Repro steps:

1. In a OnDestinationChangedListener, set things up so that if the new destination is A, nav to B.
2. Set the current destination to A.
3. Add the OnDestinationChangedListener to the NavController.

Expected Result: OnDestinationChangedListener receives callback when it is set, and then receives a callback when it causes navigation to B.

Actual Result: OnDestinationChangedListener receives callback when it is set, and then DOES NOT receive a callback when it causes navigation to B.

After the OnDestinationChangedListener is set, this sort of reentrant call works as would be expected, but when getting the callback after having set the OnDestinationChangedListener, it does not.

I think this simply requires swapping

mOnDestinationChangedListeners.add(listener);

and

if (!mBackStack.isEmpty()) {
            NavBackStackEntry backStackEntry = mBackStack.peekLast();
            listener.onDestinationChanged(this, backStackEntry.getDestination(),
                    backStackEntry.getArguments());
        }

in NavController.java. :)