IllegalStateException when popping nested graph [190265699]

Fixed

Bug

Status Update

No update yet.

Description

jo...@olavstoppen.no

created issue #1

Jun 7, 2021 10:19AM

Component used: Navigation

Version used: 2.4.0-beta02

Devices/Android versions reproduced on: Pixel 3, Huawei P20 Pro, emulator, Android 11, 12

I have a main graph and a login graph. When login is done, I want to pop the entire login graph, and return to the main graph.

This action in the login graph used to work in version 2.3.0, but throws an exception in 2.4.0-beta01/2:

<action
    android:id="@+id/to_main_screen"
    app:destination="@id/main_nav_graph"
    app:popUpTo="@id/login_nav_graph"
    app:popUpToInclusive="true" />

The stack trace:

java.lang.IllegalStateException: popBackStack was called with androidx.navigation.NavBackStackEntry@c554768 which does not exist in back stack []
        at androidx.navigation.Navigator.popBackStack(Navigator.kt:185)
        at androidx.navigation.NavController.popBackStackInternal(NavController.kt:202)
        at androidx.navigation.NavController.popBackStackInternal(NavController.kt:455)
        at androidx.navigation.NavController.popBackStackInternal$default(NavController.kt:413)
        at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1533)
        at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1466)
        at androidx.navigation.NavController$navigate$7.invoke(NavController.kt:1437)
        at androidx.navigation.NavController$navigate$7.invoke(NavController.kt:1435)
        at androidx.navigation.NavController$NavControllerNavigatorState.add(NavController.kt:215)
        at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
        at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
        at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:83)
        at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:49)
        at androidx.navigation.NavController.navigateInternal(NavController.kt:188)
        at androidx.navigation.NavController.navigate(NavController.kt:1435)
        at androidx.navigation.NavController.navigate(NavController.kt:1221)
        at androidx.navigation.NavController.navigate(NavController.kt:1149)
        at androidx.navigation.NavController.navigate(NavController.kt:1575)
        at my.app.features.login.login.LoginUIKt$LoginScreen$2.invoke(LoginUI.kt:65)
        at my.app.features.login.login.LoginUIKt$LoginScreen$2.invoke(LoginUI.kt:64)
        at my.app.features.login.LoginResultHandlerKt$LoginResultHandler$1.invoke(LoginResultHandler.kt:38)
        at my.app.features.login.LoginResultHandlerKt$LoginResultHandler$1.invoke(LoginResultHandler.kt:34)
        at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchSideEffects(Composition.kt:789)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:640)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:478)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:415)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1003)
        at android.view.Choreographer.doCallbacks(Choreographer.java:826)
        at android.view.Choreographer.doFrame(Choreographer.java:757)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:990)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7727)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)

Comments

il...@google.com <il...@google.com> #2Jun 7, 2021 05:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jo...@olavstoppen.no <jo...@olavstoppen.no> #3Jun 8, 2021 09:37AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

jo...@olavstoppen.no <jo...@olavstoppen.no> #4Jun 8, 2021 09:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

jo...@gmail.com <jo...@gmail.com> #5Jun 8, 2021 02:51PM

Trying to recreate this issue in a sample project as well, but I am seeing the same thing. However I am navigating by id instead of action.

an...@gmail.com <an...@gmail.com> #6Jun 8, 2021 08:07PM

Have the same issue with Navigation Component v2.4.0-alpha02, and no issue with 2.3.0
Here is the sample project that reproduces the issue:

https://github.com/eugene-kirzhanov/nav-test

il...@google.com <il...@google.com> #7Jun 9, 2021 12:44AM

Assigned to il...@google.com.

While the project in comment#6 is absolutely the wrong way to do conditional navigation (instead, you should follow the guide for login, it does reproduce the issue reliably enough for us to pinpoint what the problem is.

il...@google.com <il...@google.com> Jun 9, 2021 03:40AM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #8Jun 9, 2021 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 91744799f42b2b5bc42c727a17cd3618eb232c01
Author: Ian Lake <ilake@google.com>
Date: Tue Jun 08 19:02:25 2021

Ensure that NavGraphNavigator stack order remains correct

When popping the root graph, the root graph
needs to be added to the front of the
hierarchy to ensure that the
navigatorBackStack for the NavGraphNavigator
is rebuilt in the correct order.

This ensures that future popBackStack() calls
will find that the NavController's back stack
ordering matches the NavigatorState of the
NavGraphNavigator, avoiding an
IllegalStateException.

Test: new NavControllerTest test passes
BUG: 190265699
Relnote: "Fixed an IllegalStateException when
calling popBackStack() after previously popping
the root graph of the NavController."

Change-Id: I2a330acdd339aece36455aa0da37d0609767552c

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/androidTest/res/navigation/nav_multiple_navigation.xml
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1731130

il...@google.com <il...@google.com> #9Jun 9, 2021 05:26PM

Marked as fixed.

We've fixed the underlying issue (related to popping the root graph, then navigating to another nested graph) internally and it will be available in Navigation 2.4.0-alpha03.