Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 6b8ddd6cc0bc6df558c5c0e009708d4fbae10a77
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jun 09 18:25:10 2021
Revert "Override fitSystemWindows in FragmentContainerView"
This reverts commit df4b3e976b54c76a3b1178b9543402605f27711c.
Bug: 190622202
Fixes: 189277899
Reason for revert: `fitsSystemWindows` is used by other components (i.e. `CoordinatorLayout` and `DrawerLayout`) to trigger custom behavior, so making this throw can cause apps to crash without them actually setting `fitsSystemWindow=\"true\"`. Since it changes behavior, this is not an actual no-op and we should support it.
Change-Id: I7c0e9ba47359a68dacd308e36e49851bb15a22ef
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
https://android-review.googlesource.com/1732213
Branch: androidx-main
commit 6b8ddd6cc0bc6df558c5c0e009708d4fbae10a77
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jun 09 18:25:10 2021
Revert "Override fitSystemWindows in FragmentContainerView"
This reverts commit df4b3e976b54c76a3b1178b9543402605f27711c.
Bug: 190622202
Fixes: 189277899
Reason for revert: `fitsSystemWindows` is used by other components (i.e. `CoordinatorLayout` and `DrawerLayout`) to trigger custom behavior, so making this throw can cause apps to crash without them actually setting `fitsSystemWindow=\"true\"`. Since it changes behavior, this is not an actual no-op and we should support it.
Change-Id: I7c0e9ba47359a68dacd308e36e49851bb15a22ef
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
il...@google.com
We've reverted the change in fitsSystemWindows="true" on FragmentContainerView, which will remove this exception. This will be available in Fragment 1.4.0-alpha03.
Description
Component used: Fragment
Version used: 1.4.0-alpha02
But it doesn't use
fitsSystemWindows="true"on that FragmentContainerView at all. It seems like eitherfitsSystemWindows()is the wrong place for this check or something is wrong with this check.