FragmentContainerView crahes on API 19, complaining about fitsSystemWindows [190622202]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jun 9, 2021 05:54PM

Component used: Fragment

Version used: 1.4.0-alpha02

Muzei crashes when ran on an API 19 device:

java.lang.UnsupportedOperationException: FragmentContainerView does not support
fitSystemWindows(). Insets should be handled directly by a fragment's view.
        at androidx.fragment.app.FragmentContainerView.fitSystemWindows(
        FragmentContainerView.java:255)

But it doesn't use fitsSystemWindows="true" on that FragmentContainerView at all. It seems like either fitsSystemWindows() is the wrong place for this check or something is wrong with this check.

Comments

il...@google.com <il...@google.com> Jun 9, 2021 06:27PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jun 9, 2021 07:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

il...@google.com <il...@google.com> #3Jun 9, 2021 11:07PM

Marked as fixed.

We've reverted the change in b/187304502 that attempted to disallow the usage of fitsSystemWindows="true" on FragmentContainerView, which will remove this exception. This will be available in Fragment 1.4.0-alpha03.

Issue 190622202

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jun 9, 2021 06:27PM

ap...@google.com <ap...@google.com> #2Jun 9, 2021 07:50PM

il...@google.com <il...@google.com> #3Jun 9, 2021 11:07PM

Add comment

Issue metadata