Dialogs have capped width to Android default, without any option to override [190810877]

Fixed

Feature Request

Status Update

No update yet.

Description

po...@google.com

created issue #1

Jun 11, 2021 01:34PM

No description yet.

Comments

po...@google.com <po...@google.com> Jun 11, 2021 01:34PM

Assigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Jun 15, 2021 08:07PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 65325ee6397a9e768cfc145b112942a8dca6d380
Author: Mihai Popa <popam@google.com>
Date: Fri Jun 11 14:35:34 2021

Alow Dialogs to use the entire screen width

Relnote: "Dialogs are now able to use the entire screen width."
Fixes: 190810877
Test: DialogTest
Change-Id: I83929941b29e5afe443b7472ff36e46b1ccc8108

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogScreenshotTest.kt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta10.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt

https://android-review.googlesource.com/1733818

to...@gmail.com <to...@gmail.com> #3Jul 2, 2021 08:58AM

Seems this was changed as a major breaking change.

By default now dialogs are full screen and to be able to revert to previous state we need usePlatformDefaultWidth = true that require @OptIn(ExperimentalComposeUiApi::class)

Experimental API in production release to just have a dialog the normal size seems hard to explain.

ti...@gmail.com <ti...@gmail.com> #4Jul 4, 2021 09:50PM

I'll second that, seems like it's more appropriate to have usePlatformDefaultWidth defaults to true

pa...@google.com <pa...@google.com> #5Jul 6, 2021 10:27AM

This was reverted in https://android-review.googlesource.com/c/platform/frameworks/support/+/1756789

po...@google.com <po...@google.com> #6Jul 6, 2021 10:39AM

(note that the CL in comment#5 only changed the default to true, while it is still possible to disable the capping)

Issue 190810877