Provide an API to group modifiers under one InspectorInfo [191017532]

Fixed

Bug

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Jun 14, 2021 01:41PM

Currently we use Modifier.composed in many places to 'wrap' modifiers with a new InspectorInfo, while ignoring any infos used internally in the implementation detail of the modifiers.

For example, Modifier.selectable currently looks like:

composed(
    factory = {
        Modifier.clickable(
            enabled = enabled,
            role = role,
            interactionSource = interactionSource,
            indication = indication,
            onClick = onClick
        ).semantics {
            this.selected = selected
        }
    },
    inspectorInfo = debugInspectorInfo {
        name = "selectable"
        properties["selected"] = selected
        properties["enabled"] = enabled
        properties["role"] = role
        properties["interactionSource"] = interactionSource
        properties["indication"] = indication
        properties["onClick"] = onClick
    }
)

In this case using composed is important, as we want to hide the clickable's InspectorInfo, and replace it with a more meaningful one for selectable.

However, using Modifier.composed like this when there are no Composable functions being called in the implementation is expensive - it means that the modifier can never be skipped, and this can cause performance degradation. As a result, this shouldn't be composed, and we will need a new specific API to ignore the internal info.

Comments

lp...@google.com <lp...@google.com> #2Jun 14, 2021 01:42PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ap...@google.com <ap...@google.com> #3Jun 17, 2021 12:41AM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

jl...@google.com <jl...@google.com> Aug 10, 2021 10:34PM

Accepted by jl...@google.com.

ap...@google.com <ap...@google.com> #4Aug 20, 2021 10:31PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

lp...@google.com <lp...@google.com> #5Aug 21, 2021 07:09PM

Status: Assigned (reopened)

deleted

ap...@google.com <ap...@google.com> #6Aug 26, 2021 07:13PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Aug 26, 2021 07:13PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

ap...@google.com <ap...@google.com> #8Aug 26, 2021 07:13PM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

jl...@google.com <jl...@google.com> #9Aug 30, 2021 10:40PM

Marked as fixed.

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭