Fixed
Status Update
Comments
lp...@google.com <lp...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
jl...@google.com <jl...@google.com>
lp...@google.com <lp...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit ed0f91bff603994abc7102301310bf452d9e1637
Author: Jens Ole Lauridsen <jlauridsen@google.com>
Date: Wed Aug 25 09:14:36 2021
Redo the implementation of inspectable
The foldIn and foldOut logic did not work well when combined with
composed modifiers which implementation is calling foldIn repeatedly.
Instead use a start and end marker in the list of Modifier elements.
This fixes a set of tests that would fail with the earlier
implementation.
Bug: 191017532
Test: Fixes existing tests after using inspectable
Relnote: Redo implementation of inspectable
Change-Id: I927bc731712d81f47aefdf946f778047c7645b26
M compose/ui/ui-inspection/src/main/java/androidx/compose/ui/inspection/inspector/ParameterFactory.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/InspectableValueTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectableValue.kt
https://android-review.googlesource.com/1809076
Branch: androidx-main
commit ed0f91bff603994abc7102301310bf452d9e1637
Author: Jens Ole Lauridsen <jlauridsen@google.com>
Date: Wed Aug 25 09:14:36 2021
Redo the implementation of inspectable
The foldIn and foldOut logic did not work well when combined with
composed modifiers which implementation is calling foldIn repeatedly.
Instead use a start and end marker in the list of Modifier elements.
This fixes a set of tests that would fail with the earlier
implementation.
Bug: 191017532
Test: Fixes existing tests after using inspectable
Relnote: Redo implementation of inspectable
Change-Id: I927bc731712d81f47aefdf946f778047c7645b26
M compose/ui/ui-inspection/src/main/java/androidx/compose/ui/inspection/inspector/ParameterFactory.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/InspectableValueTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectableValue.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit fd22208ed7a4d4b9978e55d2547b6762a41210ef
Author: Jens Ole Lauridsen <jlauridsen@google.com>
Date: Mon Aug 23 14:22:53 2021
Do not include preceding modifiers in wrapped inspectable
Bug: 191017532
Test: Fixes existing tests after using inspectable
Relnote: Changed parameter name of inspectable to match composed
Change-Id: I3a482c9f64ef0f7cc5a5a59cecaec010ca001e3f
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectableValue.kt
https://android-review.googlesource.com/1806637
Branch: androidx-main
commit fd22208ed7a4d4b9978e55d2547b6762a41210ef
Author: Jens Ole Lauridsen <jlauridsen@google.com>
Date: Mon Aug 23 14:22:53 2021
Do not include preceding modifiers in wrapped inspectable
Bug: 191017532
Test: Fixes existing tests after using inspectable
Relnote: Changed parameter name of inspectable to match composed
Change-Id: I3a482c9f64ef0f7cc5a5a59cecaec010ca001e3f
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectableValue.kt
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit e5a77235e4d05b3d0690ee9f3c8297a34ebc17ef
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Sat Aug 21 01:57:02 2021
Fixes existing UnnecessaryComposedModifier issues
Bug: b/191017532
Test: lintDebug
Change-Id: I1a4db29446accdd136e4d94a855fc0f3e25b58d7
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SelectableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ShadowTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/Shadow.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/KeyInputModifier.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/input/key/KeyInputModifierTest.kt
https://android-review.googlesource.com/1804063
Branch: androidx-main
commit e5a77235e4d05b3d0690ee9f3c8297a34ebc17ef
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Sat Aug 21 01:57:02 2021
Fixes existing UnnecessaryComposedModifier issues
Bug:
Test: lintDebug
Change-Id: I1a4db29446accdd136e4d94a855fc0f3e25b58d7
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SelectableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ShadowTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/Shadow.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/KeyInputModifier.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/input/key/KeyInputModifierTest.kt
jl...@google.com <jl...@google.com> #9
This should be fixed with the 3 listed commits above.
Description
Currently we use
Modifier.composed
in many places to 'wrap' modifiers with a newInspectorInfo
, while ignoring any infos used internally in the implementation detail of the modifiers.For example,
Modifier.selectable
currently looks like:In this case using
composed
is important, as we want to hide theclickable
'sInspectorInfo
, and replace it with a more meaningful one forselectable
.However, using
Modifier.composed
like this when there are no Composable functions being called in the implementation is expensive - it means that the modifier can never be skipped, and this can cause performance degradation. As a result, this shouldn't becomposed
, and we will need a new specific API to ignore the internal info.