Fixed
Status Update
No update yet.
Comments
al...@google.com
se...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 93dc6213fe2e74aa9c9d3dcdb4551c6ad3a85ba4
Author: sanura <sanura@google.com>
Date: Thu Mar 16 01:59:33 2023
Add private initViewTreeOwners() to AppCompatDialog
Ensure that AppCompatDialog also sets initial view
tree owners, since it does not call through to
super.setContentView(), which would set them via
ComponentDialog.
RelNote: "`AppCompatDialog` now correctly sets the `LifecycleOwner`, `SavedStateRegistryOwner`, and `OnBackPressedDispatcherOwner` on the dialog's decor view via the ViewTree APIs, fixing issues when hosting a ComposeView within an AppCompatDialog. AppCompat now depends on Activity 1.7.0."
Bug: 261314581
Test: AppComptaDialogTest
Change-Id: Ib28abb12cc3c617b9ffed9e1450e48308dc7c3df
M appcompat/appcompat/build.gradle
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatDialogTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialog.java
https://android-review.googlesource.com/2493316
Branch: androidx-main
commit 93dc6213fe2e74aa9c9d3dcdb4551c6ad3a85ba4
Author: sanura <sanura@google.com>
Date: Thu Mar 16 01:59:33 2023
Add private initViewTreeOwners() to AppCompatDialog
Ensure that AppCompatDialog also sets initial view
tree owners, since it does not call through to
super.setContentView(), which would set them via
ComponentDialog.
RelNote: "`AppCompatDialog` now correctly sets the `LifecycleOwner`, `SavedStateRegistryOwner`, and `OnBackPressedDispatcherOwner` on the dialog's decor view via the ViewTree APIs, fixing issues when hosting a ComposeView within an AppCompatDialog. AppCompat now depends on Activity 1.7.0."
Bug: 261314581
Test: AppComptaDialogTest
Change-Id: Ib28abb12cc3c617b9ffed9e1450e48308dc7c3df
M appcompat/appcompat/build.gradle
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatDialogTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialog.java
se...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 6b7a0f963d43aa6a06b461d62743ed81adddce40
Author: sanura <sanura@google.com>
Date: Thu Mar 16 23:01:38 2023
Open up initViewTreeOwners() API for ComponentDialog and ComponentActivity
Making initViewTreeOwners() a public API in ComponentDialog
and ComponentActivity so it can be used by AppCompat.
RelNote: "`ComponentDialog` and `ComponentActivity` now
contain public API `initViewTreeOwners()` to be used to
initialize all view tree owners before setting the
content view."
Bug: 261314581
Test: all tests pass
Change-Id: Ibdce0a994b0daddc090e4ff58583ccba71612870
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
https://android-review.googlesource.com/2493317
Branch: androidx-main
commit 6b7a0f963d43aa6a06b461d62743ed81adddce40
Author: sanura <sanura@google.com>
Date: Thu Mar 16 23:01:38 2023
Open up initViewTreeOwners() API for ComponentDialog and ComponentActivity
Making initViewTreeOwners() a public API in ComponentDialog
and ComponentActivity so it can be used by AppCompat.
RelNote: "`ComponentDialog` and `ComponentActivity` now
contain public API `initViewTreeOwners()` to be used to
initialize all view tree owners before setting the
content view."
Bug: 261314581
Test: all tests pass
Change-Id: Ibdce0a994b0daddc090e4ff58583ccba71612870
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
se...@google.com
This has been fixed internally and will be available in the Activity 1.8.0-alpha03 release.
se...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.appcompat:appcompat:1.7.0-alpha03
se...@google.com
Coco73g11@gmail.com
Galaxy 3571881034
199001
On Wed, Mar 29, 2023, 11:36 PM <buganizer-system@google.com> wrote:
Galaxy 3571881034
199001
On Wed, Mar 29, 2023, 11:36 PM <buganizer-system@google.com> wrote:
se...@google.com
For locale updates on a custom KeyListener - recommendation is to implement your own KeyListener that handles locale and call it directly (skipping the EditText path).
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 72e50a813e3af970adfaecc8eff3ce22c6d5b827
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jun 16 15:51:17 2021
Bugfix: Don't reset inputType in AppCompatEditText
Calling setKeyListener in the AppCompatEditText constructor reset the
input type specified in XML. Instead, only on the constructor call
restore the input type after setting the EmojiCompat key listener.
The platfrom behavior is retained for AppCompatEditText.setKeyListener,
which will cause the inputType to be reset in setKeyListener on O+.
Bug:
Test: New unit test
Relnote: "Fix bug in AppCompatEditText that will reset the inputType
specified in XML to remove variations. This bug was introduced in
AppCompat 1.4.0-alpha01."
Change-Id: I9df3655f05312806c46875e9d5603fe48154dd8e
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
https://android-review.googlesource.com/1738673
Branch: androidx-main
commit 72e50a813e3af970adfaecc8eff3ce22c6d5b827
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jun 16 15:51:17 2021
Bugfix: Don't reset inputType in AppCompatEditText
Calling setKeyListener in the AppCompatEditText constructor reset the
input type specified in XML. Instead, only on the constructor call
restore the input type after setting the EmojiCompat key listener.
The platfrom behavior is retained for AppCompatEditText.setKeyListener,
which will cause the inputType to be reset in setKeyListener on O+.
Bug:
Test: New unit test
Relnote: "Fix bug in AppCompatEditText that will reset the inputType
specified in XML to remove variations. This bug was introduced in
AppCompat 1.4.0-alpha01."
Change-Id: I9df3655f05312806c46875e9d5603fe48154dd8e
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
al...@google.com
Just a note for process's sake -- we don't need to cherry-pick this in a bugfix since 1.4.0 hasn't gone stable yet.
se...@google.com
bo...@googlemail.com
Just a note for process's sake -- we don't need to cherry-pick this in a bugfix since 1.4.0 hasn't gone stable yet.
Do I understand correctly that you don't want to put this bug in the release notes? Is it because, it's a little embarrassing :D (just kidding) that this bug has survived two alpha versions or because it was security related? I mean all others reported bugs are always listed in the release notes.
But hey I'm just a small developer and respect the decisions of google people. Just wanted to make myself important :D
al...@google.com
No, it will be in release notes. The process note is ack'ing that this is a
high priority bug, but that it wasn't a bug affecting the previously
released stable version such that it would require an extra release.
On Fri, Jun 18, 2021, 4:52 AM <buganizer-system@google.com> wrote:
high priority bug, but that it wasn't a bug affecting the previously
released stable version such that it would require an extra release.
On Fri, Jun 18, 2021, 4:52 AM <buganizer-system@google.com> wrote:
dm...@gmail.com
Seems like this fix broke following behavior:
I use code below to display EditText in which user can type IP-address
<com.google.android.material.textfield.TextInputEditText
...
android:inputType="numberDecimal"
android:digits="0123456789."
...
/>
For all previous releases (including 1.4.0-alpha02) I got numeric keyboard, which allowed me to enter several dots while entering IP.
In release 1.4.0-alpha03 I can only input first dot and the next dot cannot be placed.
Maybe this is wrong issue for this, but I didnt find any better match.
I use code below to display EditText in which user can type IP-address
<com.google.android.material.textfield.TextInputEditText
...
android:inputType="numberDecimal"
android:digits="0123456789."
...
/>
For all previous releases (including 1.4.0-alpha02) I got numeric keyboard, which allowed me to enter several dots while entering IP.
In release 1.4.0-alpha03 I can only input first dot and the next dot cannot be placed.
Maybe this is wrong issue for this, but I didnt find any better match.
al...@google.com
Please file the regression as a new issue.
ma...@gmail.com
Comment has been deleted.
Description
Component used: EditText Version used: Version 1.4.0-alpha02 Devices/Android versions reproduced on: Pixel 3a/4a/5
It seems that set the inputType over xml doesn't work anymore. I have attached a demo project where you can reproduce this issue. With Version 1.3.0 everything working fine.
Just simple things like:
are not working anymore. When you set it programmatically everything is working fine:
Also more critical things like 'textPassword' are not working correctly. The password doesn't show but the keyboard (in this sample gboard) is showing auto suggestions!. When you set the InputType programmatically auto suggestions got hidden.
I think it is a high priority thing because it is not immediately recognizable.