Directly integrate Navigation and SlidingPaneLayout [191276636]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jun 16, 2021 06:28PM

Component used: Navigation

Version used: 2.4.0-alpha03

The Create a two pane layout guide talks through the pattern of using a SlidingPaneLayout that has a NavHostFragment as its detail pane where clicking on an item in your list pane would navigate() to a new destination in the detail pane.

It would be nice if this pattern was directly supported in Navigation, removing the need to manually integrate with the system back button or write the boilerplate XML layout.

Comments

ap...@google.com <ap...@google.com> #2Jun 24, 2021 01:31AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3Jun 24, 2021 04:21AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

il...@google.com <il...@google.com> #4Jun 24, 2021 08:44PM

Marked as fixed.

deleted

ir...@gmail.com <ir...@gmail.com> #5Aug 31, 2022 09:43PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ir...@gmail.com <ir...@gmail.com> #6Aug 31, 2022 10:05PM

Hi again, I fixed, hehe. The problem was I was using

ListPaneBinding.inflate(inflater)

instead of

ListPaneBinding.inflate(inflater, container, false)

when inflating the list pane.

te...@gmail.com <te...@gmail.com> #7Jan 12, 2023 01:17PM

Hello, is there a way to connect the toolbar app configuration of an outer navigation graph to the inner one of the AbstractListDetailFragment? When opening the details pane while in portrait mode you don't get a back arrow in the toolbar by default. Is there a way to get the toolbar to understand to add a back arrow just for the details pane in portrait mode or do I need to create a custom solution?

te...@gmail.com <te...@gmail.com> #8Jan 12, 2023 01:22PM

Another thought - You define the two_pane_fragment.xml in your example (

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/integration-tests/testapp/src/main/res/layout/two_pane_fragment.xml), yet, it seems to be unused. The TwoPaneFragment class in the example does not inflate it, nor does the AbstractListDetailFragment. Actually, AbstractListDetailFragment creates a FragmentContainerView itself in its onCreateView method. However, in the guide (

https://developer.android.com/develop/ui/views/layout/twopane#navigation) you claim that this XML is needed. How should I think about this?