Calling launch as part of composition Lint check [191347220]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

mv...@google.com

created issue #1

Jun 17, 2021 12:52PM

The rememberLauncherForActivityResult API in androidx.activity:activity-compose should warn when the developer attempts to call it in a composable scope.

At the moment, doing this throws a runtime exception but it'd be nice to warn earlier and not having to wait for the app to run.

Comments

il...@google.com <il...@google.com> #2Jun 17, 2021 10:22PM

Reassigned to jb...@google.com.

I had seen so many recommendations on phonixhacker41 @gmail. com, so I contacted him to help me Clone my wife cell phone and WhatsApp. Just like Magic, I got the files to get it done and I have access to my wife phone. He was really efficient and I have access to everything including phone calls, logs and location. What I like about the job is that it is not traceable. I have this working for 3 months now. I am just another satisfied customers.you can contact them through phonixhacker41 @

gmail.com or via WhatsApp ‪+1 (916) 250‑1771‬

lp...@google.com <lp...@google.com> #3Jun 17, 2021 10:52PM

We are a team of highly efficient software developers and cyber-site hackers. We render
*School grade hack,
*hack into email accounts,
*all social media accounts,
*school database to clear or change grades,
*Retrieval of lost documents
*DUIs
*company records and systems,
*clearing bad driving and criminal records,
+ credit score hack,
+ Monitor your partners phone,Whatsapp,Facebook.
You should visit us
Phonixhacker41 @gmail. com or via WhatsApp ‪+1 (916) 250‑1771‬

il...@google.com <il...@google.com> #4Jun 17, 2021 11:02PM

Rahul, don't know if this is a real issue or a benchmark being coded poorly thing. Passing along due to profileinstaller.

lp...@google.com <lp...@google.com> #5Jun 17, 2021 11:04PM

Hello!! be warned, most of these so called hackers here are impostors, I know how real hackers work, they never advertise themselves in such a credulous manner and they are always discrete. I’ve been ripped off so many times out of desperation trying to find urgent help until my friend finally introduced me to a reliable hacker who’s services are cheap and affordable, discretion and delivers, he does all sorts of hacks but he helped me Hacked my cheating boyfriend email/facebook, whatsapp, instagram, with snapchat, I have made him my permanent hacker and you can as well enjoy his services. You can contact him at: (TECHCROWNHACKER @ GMAIL COM) and after his work also endeavor to spread the good news on his work and how he helped you.

mv...@google.com <mv...@google.com> #6Jun 18, 2021 05:38AM

Hi Marcelo, can you please take a look at this when you get a chance ? If not, I can come and take a look when I get back.

wr...@gmail.com <wr...@gmail.com> #7Aug 11, 2021 12:04AM

I'm pretty sure the offending PR here is aosp/2333568 - that is the only PR touching the profile transcoding.

It fixes an important bug with compressed profiles but it seems that the new code is slower than before.

wr...@gmail.com <wr...@gmail.com> #8Aug 11, 2021 12:18AM

If you look in the dashboard, the commit link is wrong, since it doesn't encompass all builds since the previous (9385400). Correct build range link is here, which includes Ben's CL: https://android-build.googleplex.com/builds/9385668/branches/aosp-androidx-main/targets/_/cls?end=9385400&inclusiveStart=1&inclusiveEnd=0

(If a build goes missing for any reason, it corrupts the commit link. In general, you can always go to dashboard, and create range link like the above)

wr...@gmail.com <wr...@gmail.com> #9Aug 11, 2021 12:37AM

Yes, it looks like my change introduced this regression. If I read this dashboard correctly, before the change it took a minimum of 0.0012 ms to install a profile and now it takes ~ 1.3 ms.
That would mean the change makes opening the file slower by about 1000 times.

Chris: Given this runs on a background thread and is not blocking app startup, is it urgent to address this or can it wait for the next release cycle?

ap...@google.com <ap...@google.com> #10Aug 31, 2021 09:52PM

The number in the triage page is synthetic, you need to click through to the dashboard here to see the real nanos. It went from 0.2ms to 46ms, which is a huge slowdown. We should fix this before cherry-picking / releasing this change.

jb...@google.com <jb...@google.com> #11Aug 31, 2021 10:03PM

Marked as fixed.

Uploaded aosp/2355662 to address the problem.