Request: Composable function to load string plural resources [191375123]

Fixed

Bug

Status Update

No update yet.

Description

ri...@monzo.com

created issue #1

Jun 18, 2021 02:38PM

Component used: compose.ui:ui Version used: 1.0.0-beta04 Devices/Android versions reproduced on: Any

I was looking to see if we have a way to load plural string resources and didn't spot anything in AOSP unless I'm missing it / another way to do this idiomatically?

https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-compose-release/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/StringResources.android.kt

Example plural string resource:

<plurals name="due_in_format">
    <item quantity="one">Due in %d day</item>
    <item quantity="other">Due in %d days</item>
</plurals>

Workaround:

@Composable
fun stringPluralResource(
    @PluralsRes resId: Int, quantity: Int, vararg formatArgs: Any? = emptyArray()
): String {
    return LocalContext.current.resources
        .getQuantityString(resId, quantity, *formatArgs)
}

Comments

an...@google.com <an...@google.com> Jul 12, 2021 02:39PM

Assigned to ae...@google.com.

kl...@google.com <kl...@google.com> #2Mar 1, 2022 07:04PM

Accepted by kl...@google.com.

Assigning to myself, someone submitted an external fix and I'll help land it: https://android-review.googlesource.com/c/platform/frameworks/support/+/1999932

ap...@google.com <ap...@google.com> #3Mar 3, 2022 06:17PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d2cc33eb7036a34dd6d7858f83735428929fa5ac
Author: Karl Lindmark <karl.lindmark@swedbank.se>
Date: Thu Feb 24 22:40:52 2022

Add support for plurals resources in Compose

Fixes:

b/191375123

Test: Two new tests in StringResourcesTest.kt for plurals resources

Relnote: "Plural resources are now supported via the `pluralStringResource` functions."
Change-Id: Ib2f23431f0fc24a5c717a21b6309a928b2f78b91

M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/StringResources.android.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/res/StringResourcesTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/androidAndroidTest/res/values/donottranslate-strings.xml
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1999932

Issue 191375123

Description

Issue summary

Comments

an...@google.com <an...@google.com> Jul 12, 2021 02:39PM

kl...@google.com <kl...@google.com> #2Mar 1, 2022 07:04PM

ap...@google.com <ap...@google.com> #3Mar 3, 2022 06:17PM

Add comment

Issue metadata