Steps to reproduce

Following the documentation for integrating in-app reviews...

Add Play Core to a project implementation 'com.google.android.play:core:1.10.0' and sync Gradle dependencies
Within an Activity, try adding the sample code from the documentation and import classes via Android Studio:

ReviewManager manager = ReviewManagerFactory.create(this);
Task<ReviewInfo> request = manager.requestReviewFlow();
request.addOnCompleteListener(task -> {
    if (task.isSuccessful()) {
        // We can get the ReviewInfo object
        ReviewInfo reviewInfo = task.getResult();
    } else {
        // There was some problem, log or handle the error code.
        @ReviewErrorCode int reviewErrorCode = ((TaskException) task.getException()).getErrorCode();
    }
});

Current outcome:

Receive "Cannot resolve symbol TaskException" error

Context:

Searching for TaskException across all of "developer.android.com" brings only one result — RuntimeExecutionException
The JavaDocs for RuntimeExecutionException say:

TaskException version of ExecutionException.

See also:

Task.getResult(Class)

Which isn't very clear. The docs for "Task.getResult" are also a bit confusing:

Throws
IllegalStateException	if the Task is not yet complete
	if the Task failed with an exception of type X
RuntimeExecutionException	if the Task failed with an exception that was not of type X
Throwable

Desired outcome:

It would be great if:

The Developer Guide could be updated so that the code is correct (I presume it should just be casting to RuntimeExecutionException here)
The Javadoc on Task.getResult() is cleaned-up so that it makes sense, e.g —
- What is the exception sub-class that gets thrown "if the Task failed with an exception of type X"?
- What is "type X"?
- When is Throwable thrown?

Issue 191394507

Links (5)

Issue metadata