Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
il...@google.com <il...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
R8 3.1 (full mode) will remove annotations from classes, fields and methods that are not matched by a this change is to prevent R8 from having to retain all annotations in the program, when only a few are typically needed.
-keep
rule, even in the presence-keepattributes *Annotation*
. The motivation forWith R8 3.1 in full mode, the following rule is therefore needed to preserve
@Navigator.Name
annotations on subclasses ofandroidx.navigation.Navigator
:This would be good to add to the consumer Proguard rules of
androidx.navigation
.(This showed up while trying to revert commit "Disable R8 full mode for now" @https://github.com/chrisbanes/tivi/commit/9720aa34f6c8b9e5260129ab6d05b44e84d3721c .)