IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support
Branch: androidx-main

commit 6bd2347ff259c28b34789c8569b7a298d2a8fd8d
Author: Clara Fok <clarafok@google.com>
Date:   Fri Jul 09 12:53:22 2021

    Implement Invalid return type in PagingSource
   
    Added third return type for LoadResult sealed class in PagingSource. It
    was added as a support feature to handle race scenarios between data loads
    and database invalidations, such as if Room's InvalidationTracker does
    not propagate invalidation signal to the PagingSource in time and the
    PagingSource continues querying an updated database. This can result in
    data being loaded onto a stale PageFetcherSnapshot causing duplicated or
    missing data. Related bug regarding race scenario in Room b/191806126.
   
    For example, if data was deleted and items shifted positions,
    positionally-keyed paging sources can end up loading duplicated items.
   
    Paging handles this return type by discarding the loaded data and
    invalidating the paging source. This will trigger a new paging source to
    be generated. This return type is also supported for Paging2 APIs
    leveraging PagingSource such as LivePagedList and RxPagedList.
   
    Aside from handling invalid data due to races, this return type can be
    leveraged in general where the database or network returns potentially
    invalid or stale data that needs to be discarded.
   
    Bug: 192013267
    Test: ./gradlew :paging:paging-common:test
    Relnote: "A third LoadResult return type LoadResult.Invalid is added to
        PagingSource. When a PagingSource.load returns
        LoadResult.Invalid, paging will discard the loaded data and
        invalidate the PagingSource. This return type is designed to
        handle potentially invalid or stale data that can be returned
        from the database or network.
   
        For example, if the underlying database gets written into but
        the PagingSource does not invalidate in time, it may return
        inconsistent results if its implementation depends on the
        immutability of the backing dataset it loads from (e.g., LIMIT
        OFFSET style db implementations). In this scenario, it is
        recommended to check for invalidation after loading and to
        return LoadResult.Invalid, which causes Paging to discard any
        pending or future load requests to this PagingSource and
        invalidate it.
   
        This return type is also supported by Paging2 API that leverages
        LivePagedList or RxPagedList. When using a PagingSource with
        Paging2's PagedList APIs, the PagedList is immediately detached,
        stopping further attempts to load data on this PagedList and
        triggers invalidation on the PagingSource.
   
        LoadResult is a sealed class, which means this is a
        source-incomptabile change such that use cases directly using
        PagingSource.load results will have to handle LoadResult.Invalid
        at compile time. For example, Kotlin users leveraging
        exhaustive-when to check return type will have to add a check
        for Invalid type."
   
    Change-Id: Id6bd3f2544f1ba97a95a0d590353438a95fedf2a

M       paging/common/api/current.txt
M       paging/common/api/public_plus_experimental_current.txt
M       paging/common/api/restricted_current.txt
M       paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M       paging/common/src/main/kotlin/androidx/paging/PagedList.kt
M       paging/common/src/main/kotlin/androidx/paging/PagingSource.kt
M       paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M       paging/common/src/test/kotlin/androidx/paging/PageFetcherTest.kt
M       paging/common/src/test/kotlin/androidx/paging/PagedListTest.kt
M       paging/common/src/test/kotlin/androidx/paging/PagingDataDifferTest.kt
M       paging/common/src/test/kotlin/androidx/paging/PagingSourceTest.kt
M       paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RemoteMediator.kt
M       paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomViewModel.kt

https://android-review.googlesource.com/1747297

Project: platform/frameworks/support
Branch: androidx-main

commit 3882ac8364fd905c9935d38c93f84599009226d6
Author: Clara Fok <clarafok@google.com>
Date:   Fri Jul 09 14:17:48 2021

    Implement LoadResult.Invalid to handle race
   
    For non-initial loads in LimitOffsetPagingSource, loads will run Room
    InvalidationTracker's refreshVersionSync to synchronously check if
    tables have been invalidated and notify observers. If invalidated,
    load will return LoadResult.Invalid.
   
    Paging3 will handle Invalid return type by invalidating the paging
    source and closing the page event flow, such that no more loads will be
    attempted on this paging source.
   
    Note that refreshVersionSync is a temporary solution for
    LimitOffsetPagingSource to check table invalidation. Another solution
    that does not require a transaction is in development. Related b/192269858.
   
    Bug: 191806126
    Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
    Test: ./gradlew room:room-paging:cC
    Change-Id: I48634ab95949bae608374f5156a4edd0500a74a3

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/PagingSourceTest.kt
M       room/room-paging/build.gradle
M       room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M       room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt

https://android-review.googlesource.com/1761130