LimitOffsetPagingSource - Handle race between db write and paging source invalidation [191806126]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Jun 22, 2021 10:14PM

Race could happen in non-initial loads in . Discussed possible solutions

1) suspend with timeout before returning data
2) do best effort and try to return a page
3) Check for invalidation after db query but before returning the data

Related Bug: 178636235

Comments

cl...@google.com <cl...@google.com> #2Jun 24, 2021 06:28PM

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

cl...@google.com <cl...@google.com> Jun 26, 2021 12:08AM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #3Jul 13, 2021 06:52PM

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

ap...@google.com <ap...@google.com> #4Jul 14, 2021 01:24AM

Tracking sheet for which projects have been migrated.

cl...@google.com <cl...@google.com> Jul 28, 2021 06:30PM

Marked as fixed.

Issue 191806126