Fixed
Status Update
No update yet.
Comments
an...@google.com
ap...@google.com
Hi,
I also see my text cut off when I set maxLines = 2. Is it the same issue?
Box(
modifier =
Modifier.size(
width = 108dp,
height = 34dp,
),
contentAlignment = Alignment.Center,
) {
BasicText(
text = "text text text",
maxLines = 2,
autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
)
}
da...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <
Link:
Fix TextAutoSize bug with maxLines = 1
Expand for full commit details
Fix TextAutoSize bug with maxLines = 1
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult.
Test: New MultiParagraphLayoutCacheTests and manual testing
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1.
Fixes: 376834366
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689
Files:
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025
Description
Component used: Box Version used: 1.0.0-beta09 Devices/Android versions reproduced on: Nexus 5X API 29 emulator
When applying a border from a custom shape the result is not well centered.
This is the Path being applied:
fun getSuperellipseShapePath(): Path { return androidx.core.graphics.PathParser.createPathFromPathData( superEllipsePath.trimMargin() ) }
val superEllipsePath = "M3.2775,3.2775 C5.81348,0.74152 11.5,0 23,0 C34.5,0 40.18652,0.74152 42.7225,3.2775 C45.25848, 5.81348 46,11.5 46,23 C46,34.5 45.25848,40.18652 42.7225,42.7225 C40.18652,45.25848 34.5,46 23, 46 C11.5,46 5.81348,45.25848 3.2775,42.7225 C0.74152,40.18652 0,34.5 0,23 C0,11.5 0.74152, 5.81348 3.2775,3.2775 Z"