IssueTracker

Component used: AppCompatActivity

Version used: 1.3.0

Devices/Android versions reproduced on: Emulator API 28, 30, Samsung Galaxy S21 API 30, most likely all versions are affected

Each time I change the orientation of my screen, the saved instance bundle size increases by 3 elements in two different ArrayLists.

Here is the minimal example that will illustrate the issue. The additional code in the onSaveInstanceState is only there to display the issue.

class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
    }

    override fun onSaveInstanceState(outState: Bundle) {
        super.onSaveInstanceState(outState)

        val rcs = outState.getIntegerArrayList("KEY_COMPONENT_ACTIVITY_REGISTERED_RCS")
        val keys = outState.getStringArrayList("KEY_COMPONENT_ACTIVITY_REGISTERED_KEYS")

        Log.d("MainActivity", "${rcs?.size}: $rcs, $keys")
    }
}

Here is the full output when rotated 6 times: https://pastebin.com/yfE04Fmc

Mini-extract (2 rotations):

3: [1332505437, 1835553837, 670316111], [FragmentManager:StartIntentSenderForResult, ...
6: [1332505437, 91080073, 1835553837, 381123153, 1187376284, 670316111], ...
...

As you can see, each time the screen is rotated, 3 elements are added to these two entries. After rotating the screen for a while, the instance state becomes significantly bigger for no apparent reason.

I traced it back to (but can be wrong) ActivityResultRegistry, and it seems that something in the support library doesn't clean up the state with the registry.

I also tried simply putting the app in the background, which triggers the onSaveInstanceState but that did not increase the bundle size. It looks like the activity must be re-created.

When I inherit from Activity instead, the issue disappears.