Swipeable's state.progress sometimes randomly crashes with NoSuchElementException [191993377]

Fixed

Bug

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Jun 25, 2021 10:54AM

Jetpack Compose release version: 1.0.0-beta09

Android Studio Build: 2020.3.1 Beta4

I have a BottomSheetScaffold (which is based on Swipeable) and it randomly crashes. Our QA reports seeing these crashes on Android 11 device when pressing HOME and returning back, but I'm not sure if this is related, I got them just by navigating between screens IIRC.

Unfortunately I can't figure out the minimal case to attach as a project.

Here's the stacktrace:

Fatal Exception: java.util.NoSuchElementException: Key 337.99997 is missing in the map.
       at kotlin.collections.MapsKt__MapWithDefaultKt.getOrImplicitDefaultNullable(MapsKt__MapWithDefaultKt.java:24)
       at kotlin.collections.MapsKt__MapsKt.getValue(MapsKt__MapsKt.java:344)
       at androidx.compose.material.SwipeableState.getProgress(SwipeableState.java:275)
       at ru.myapp.ui.main.PortfolioMainController.ContentReadyState(PortfolioMainController.java:153)
       at ru.myapp.ui.main.PortfolioMainController$ContentReadyState$2.invoke(PortfolioMainController.java:9)
       at ru.myapp.ui.main.PortfolioMainController$ContentReadyState$2.invoke(PortfolioMainController.java:9)
       at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.java:140)
       at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(ComposerImpl.java:2156)
       at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(ComposerImpl.java:2399)
       at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(ComposerImpl.java:2578)
       at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(ComposerImpl.java:2571)
       at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(SnapshotStateKt.java:523)
       at androidx.compose.runtime.ComposerImpl.doCompose(ComposerImpl.java:2564)
       at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(ComposerImpl.java:2540)
       at androidx.compose.runtime.CompositionImpl.recompose(CompositionImpl.java:613)
       at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.java:764)
       at androidx.compose.runtime.Recomposer.access$setCloseCause$p(Recomposer.java:103)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.java:447)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.java:416)
       at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.java:34)
       at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.java:109)
       at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.java:41)
       at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.java:69)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1054)
       at android.view.Choreographer.doCallbacks(Choreographer.java:878)
       at android.view.Choreographer.doFrame(Choreographer.java:807)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1041)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:223)
       at android.app.ActivityThread.main(ActivityThread.java:7697)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:952)

Comments

an...@google.com <an...@google.com> Jun 28, 2021 12:26PM

Assigned to ma...@google.com.

za...@gmail.com <za...@gmail.com> #2Aug 1, 2021 05:00PM

Agree

Message last modified on Aug 1, 2021 05:01PM

za...@gmail.com <za...@gmail.com> #3Aug 1, 2021 05:15PM

Also it causes slider to be unusable while onValuChangeFinished != null

ap...@google.com <ap...@google.com> #4Aug 3, 2021 03:52PM

Agree, big problem, started from alpha 11 +-

[Deleted User] <[Deleted User]> #5Sep 14, 2021 12:53PM

I think this is because they are changed 1761 line of code

https://android-review.googlesource.com/c/platform/frameworks/support/+/2804280/1/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Slider.kt#271

ma...@google.com <ma...@google.com> #6Sep 14, 2021 01:33PM

Marked as fixed.

#comment1 could you provide all of your dependencies for your project that you saw the issue in? It might have been fixed by a foundational module that Material3 depends on.

[Deleted User] <[Deleted User]> #7Sep 14, 2021 01:54PM

#comment6

this is all my dependencies, and i have similar problem on material3 version 1.2.0-rc01, slider is just don't move with using onValueChangeFinish param

[versions]
agp = "8.2.2"
coil-compose = "2.5.0"
compose-shimmer = "1.2.0"
sealedx-processor = "1.0.2"
sealedx-core = "1.0.2"
vico = "2.0.0-alpha.6"
github-core = "1.9.62"
github-glassmorphic-composables = "0.0.7"
github-sandwich = "2.0.5"
gson = "2.10.1"
haze-jetpack-compose = "0.4.5"
hilt-android = "2.46"
hilt-navigation-compose = "1.1.0"
kotlin = "1.9.22"
core-ktx = "1.12.0"
junit = "4.13.2"
androidx-test-ext-junit = "1.1.5"
espresso-core = "3.5.1"
ksp = "1.9.62"
lifecycle-runtime-ktx = "2.7.0"
activity-compose = "1.8.2"
compose-bom = "2023.10.01"
moshi = "1.15.0"
moshi-kotlin-codegen = "1.15.0"
retrofit = "2.9.0"
room-runtime = "2.6.1"
stories = "1.0.2"

[libraries]
androidx-hilt-navigation-compose = { module = "androidx.hilt:hilt-navigation-compose", version.ref = "hilt-navigation-compose" }
androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room-runtime" }
androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = "room-runtime" }
coil-compose = { module = "io.coil-kt:coil-compose", version.ref = "coil-compose" }

compose-shimmer = { module = "com.valentinilk.shimmer:compose-shimmer", version.ref = "compose-shimmer" }
converter-moshi = { module = "com.squareup.retrofit2:converter-moshi", version.ref = "retrofit" }
destinationCore = { module = "io.github.raamcosta.compose-destinations:core", version.ref = "github-core" }
core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core-ktx" }
haze-jetpack-compose = { module = "dev.chrisbanes.haze:haze-jetpack-compose", version.ref = "haze-jetpack-compose" }
hilt-android = { module = "com.google.dagger:hilt-android", version.ref = "hilt-android" }
hilt-android-compiler = { module = "com.google.dagger:hilt-android-compiler", version.ref = "hilt-android" }
junit = { group = "junit", name = "junit", version.ref = "junit" }
androidx-test-ext-junit = { group = "androidx.test.ext", name = "junit", version.ref = "androidx-test-ext-junit" }
espresso-core = { group = "androidx.test.espresso", name = "espresso-core", version.ref = "espresso-core" }
destinationKsp = { module = "io.github.raamcosta.compose-destinations:ksp", version.ref = "ksp" }
lifecycle-runtime-ktx = { group = "androidx.lifecycle", name = "lifecycle-runtime-ktx", version.ref = "lifecycle-runtime-ktx" }
activity-compose = { group = "androidx.activity", name = "activity-compose", version.ref = "activity-compose" }
compose-bom = { group = "androidx.compose", name = "compose-bom", version.ref = "compose-bom" }
moshi = { module = "com.squareup.moshi:moshi", version.ref = "moshi" }
moshi-kotlin = { module = "com.squareup.moshi:moshi-kotlin", version.ref = "moshi" }
moshi-kotlin-codegen = { module = "com.squareup.moshi:moshi-kotlin-codegen", version.ref = "moshi-kotlin-codegen" }
retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
sandwich-retrofit = { module = "com.github.skydoves:sandwich-retrofit", version.ref = "github-sandwich" }
sealedx-processor = { module = "com.github.skydoves:sealedx-processor", version.ref = "sealedx-processor" }
sealedx-core = { module = "com.github.skydoves:sealedx-core", version.ref = "sealedx-core" }
skydoves-sandwich = { module = "com.github.skydoves:sandwich", version.ref = "github-sandwich" }
stories = { module = "com.github.raipankaj:Stories", version.ref = "stories" }
ui = { group = "androidx.compose.ui", name = "ui" }
ui-graphics = { group = "androidx.compose.ui", name = "ui-graphics" }
ui-tooling = { group = "androidx.compose.ui", name = "ui-tooling" }
ui-tooling-preview = { group = "androidx.compose.ui", name = "ui-tooling-preview" }
ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-manifest" }
ui-test-junit4 = { group = "androidx.compose.ui", name = "ui-test-junit4" }
material3 = { group = "androidx.compose.material3", name = "material3", version = "1.2.0-rc01" }

vico-compose-m3 = { module = "com.patrykandpatryk.vico:compose-m3", version.ref = "vico" }

[plugins]
androidApplication = { id = "com.android.application", version.ref = "agp" }
kotlinAndroid = { id = "

org.jetbrains.kotlin.android", version.ref = "kotlin" }

[bundles]

ni...@gmail.com <ni...@gmail.com> #8Sep 14, 2021 02:00PM

Ran into the same issue, the onValuChangeFinished lambda is being passed as a remember key so recreates the state if that lambda reference changes (as seen in https://issuetracker.google.com/issues/322269951#comment5). You can work around it by remembering the lambda itself.

val context = LocalContext.current
var sliderPosition by remember { mutableStateOf(0f) }
val onValueChangeFinished: () -> Unit = remember {
  { Toast.makeText(context, sliderPosition.toString(), Toast.LENGTH_SHORT).show() }
}
Text(text = sliderPosition.toString())

Slider(
    value = sliderPosition, 
    onValueChange = { sliderPosition = it }, 
    onValueChangeFinished = onValueChangeFinished
)

[Deleted User] <[Deleted User]> #9Sep 14, 2021 02:02PM

Feb 19 is a U.S. holiday, there are 12+ impacted so far, Kevin, could you please take a look on tues once you are back at work? ty!