Swipeable's state.progress sometimes randomly crashes with NoSuchElementException [191993377]

Fixed

Bug

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Jun 25, 2021 10:54AM

Jetpack Compose release version: 1.0.0-beta09

Android Studio Build: 2020.3.1 Beta4

I have a BottomSheetScaffold (which is based on Swipeable) and it randomly crashes. Our QA reports seeing these crashes on Android 11 device when pressing HOME and returning back, but I'm not sure if this is related, I got them just by navigating between screens IIRC.

Unfortunately I can't figure out the minimal case to attach as a project.

Here's the stacktrace:

Fatal Exception: java.util.NoSuchElementException: Key 337.99997 is missing in the map.
       at kotlin.collections.MapsKt__MapWithDefaultKt.getOrImplicitDefaultNullable(MapsKt__MapWithDefaultKt.java:24)
       at kotlin.collections.MapsKt__MapsKt.getValue(MapsKt__MapsKt.java:344)
       at androidx.compose.material.SwipeableState.getProgress(SwipeableState.java:275)
       at ru.myapp.ui.main.PortfolioMainController.ContentReadyState(PortfolioMainController.java:153)
       at ru.myapp.ui.main.PortfolioMainController$ContentReadyState$2.invoke(PortfolioMainController.java:9)
       at ru.myapp.ui.main.PortfolioMainController$ContentReadyState$2.invoke(PortfolioMainController.java:9)
       at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.java:140)
       at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(ComposerImpl.java:2156)
       at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(ComposerImpl.java:2399)
       at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(ComposerImpl.java:2578)
       at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(ComposerImpl.java:2571)
       at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(SnapshotStateKt.java:523)
       at androidx.compose.runtime.ComposerImpl.doCompose(ComposerImpl.java:2564)
       at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(ComposerImpl.java:2540)
       at androidx.compose.runtime.CompositionImpl.recompose(CompositionImpl.java:613)
       at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.java:764)
       at androidx.compose.runtime.Recomposer.access$setCloseCause$p(Recomposer.java:103)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.java:447)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.java:416)
       at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.java:34)
       at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.java:109)
       at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.java:41)
       at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.java:69)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1054)
       at android.view.Choreographer.doCallbacks(Choreographer.java:878)
       at android.view.Choreographer.doFrame(Choreographer.java:807)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1041)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:223)
       at android.app.ActivityThread.main(ActivityThread.java:7697)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:952)

Comments

an...@google.com <an...@google.com> Jun 28, 2021 12:26PM

Assigned to ma...@google.com.

za...@gmail.com <za...@gmail.com> #2Aug 1, 2021 05:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on Aug 1, 2021 05:01PM

za...@gmail.com <za...@gmail.com> #3Aug 1, 2021 05:15PM

Fix is up, just needs tests: https://android-review.googlesource.com/c/platform/frameworks/support/+/1783329

ap...@google.com <ap...@google.com> #4Aug 3, 2021 03:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit 32d335ae09b704ce6e52b3e80d28a1cc8cdae474
Author: Zach Klippenstein <zach.klippenstein@gmail.com>
Date: Sun Aug 01 17:14:29 2021

Fix swipeable exception when offset is very close to an anchor.

Bug: 191993377

The logic in the findBounds function that determines when the given offset is an exact match for an anchor accounts for rounding error when comparing the floats. This means that, even when an offset is considered an exact match, the actual offset value might not be exactly equal to the matching anchor value. This breaks the logic in SwipeableState's progress getter, which uses the value returned by findBounds as a key into the anchors map. If that returned value is not exactly equal, the map throws a NoSuchElementException.

This fixes the issue by making findBounds return the anchor that was considered an exact match instead of the offset value itself.

Relnote: "Fix the behavior of SwipeableState in the case where the swipe offset is within a rounding error of an anchor."

Change-Id: I03d39d25bc376314d7197484c2a707498296aa97
Test: tested manually, leaving automated tests until swipeable rewrite

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt

https://android-review.googlesource.com/1783329

an...@glovoapp.com <an...@glovoapp.com> #5Sep 14, 2021 12:53PM

Hey there!

Is there any timeline for this bugfix to hit the next minor release? I can still reproduce this crash in Compose 1.0.2.

ma...@google.com <ma...@google.com> #6Sep 14, 2021 01:33PM

Marked as fixed.

I believe this has been fixed. Could you post your code that hits this issue?

an...@glovoapp.com <an...@glovoapp.com> #7Sep 14, 2021 01:54PM

Sure.

This is the composable that uses the swipeable Modifier:

...

Box(
    Modifier.background(
        backgroundColor.copy(alpha = swipeableState.toBackgroundAlpha()),
    ),
) {
    Box(
        Modifier
            .fillMaxWidth()
            .height(constraints.maxHeight)
            .nestedScroll(nestedScrollConnection)
            .swipeable(
                state = swipeableState,
                enabled = swipeableState.currentValue == Expanded,
                anchors = mapOf(
                    maxHeightInPixels to Collapsed,
                    0f to Expanded,
                ),
                orientation = Orientation.Vertical,
                resistance = null,
                thresholds = { _, _ -> FractionalThreshold(MIN_DRAG_THRESHOLD) },
            )
            .offset {
                IntOffset(
                    x = 0,
                    y = swipeableState.offset.value.roundToInt(),
                )
            }
            .padding(top = topSpacing)
            .clip(RoundedCornerShape(topStart = Radius.S, topEnd = Radius.S))
            .background(surfaceColor),
    ) {
        Column(Modifier.fillMaxHeight()) {
            Box {
                header()
            }
            Box(Modifier.verticalScroll(scrollState)) {
                body()
            }
        }
    }
}

...

And this is the extension function that raises the exception:

@ExperimentalMaterialApi
@Composable
private fun SwipeableState<BottomSheetState>.toBackgroundAlpha(): Float {
    return if (offset.value == 0f) {
        MIN_BACKGROUND_ALPHA
    } else {
        (MIN_BACKGROUND_ALPHA - progress.fraction).coerceAtLeast(0f)
    }
}

The issue comes from the access to progress.fraction.

And here's the stacktrace:

java.util.NoSuchElementException: Key 1.8626451E-8 is missing in the map.
        at kotlin.collections.MapsKt__MapWithDefaultKt.getOrImplicitDefaultNullable(MapWithDefault.kt:24)
        at kotlin.collections.MapsKt__MapsKt.getValue(Maps.kt:344)
        at androidx.compose.material.SwipeableState.getProgress(Swipeable.kt:275)
        ...

ni...@gmail.com <ni...@gmail.com> #8Sep 14, 2021 02:00PM

It has been fixed in 1.1.0-alpha02 : https://developer.android.com/jetpack/androidx/releases/compose-material#1.1.0-alpha02 You can probably use this version for now

an...@glovoapp.com <an...@glovoapp.com> #9Sep 14, 2021 02:02PM

Perfect, thanks for the heads up!

I'd prefer to wait for the next stable release and avoid the direct access to progress.fraction for now.