ActivityResultRegistry should throw when attempting to launch and unregistered launcher [192567522]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 1, 2021 05:28PM

Currently, when using the ActivityResultRegistry, you can call launch() on an ActivityResultLauncher that is not currently registered. This means that the targeted Activity can be launched, but there will not be any result meaning the API is not behaving as intended.

Instead of allowing developers to run into this issue, we should always throw from the registry when the launcher is not registered.

Comments

ap...@google.com <ap...@google.com> #2Jul 13, 2021 01:23AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> #3Jul 14, 2021 11:54PM

Marked as fixed.

This has been fixed internally and will be released as part of Activity 1.4.0-alpha01.

pv...@gmail.com <pv...@gmail.com> #4Jan 12, 2022 06:41AM

The problem not resolved yet, its also produce in "1.4.0" version.

Fatal Exception: java.lang.IllegalStateException: Attempting to launch an unregistered ActivityResultLauncher with contract c.c@90b944b and input Intent { cmp=

package.name/.editor.EditorActivity }. You must ensure the ActivityResultLauncher is registered before calling launch().
at androidx.activity.result.ActivityResultRegistry$2.launch(ActivityResultRegistry.java:77)
at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:5)
at package.name.app.LicenceActivity.startApp(LicenceActivity.java:5)
at package.name.app.LicenceActivity.startMainActivity(LicenceActivity.java:3)
at package.name.app.LicenceActivity.access$startMainActivity(LicenceActivity.java:1)
at package.name.app.LicenceActivity$initBilling$2.onBillingServiceDisconnected(LicenceActivity.java:1)
at com.android.billingclient.api.zzaf.onServiceDisconnected(zzaf.java:4)
at android.app.LoadedApk$ServiceDispatcher.doDeath(LoadedApk.java:1902)
at android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:1917)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:233)
at android.app.ActivityThread.main(ActivityThread.java:7225)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:499)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:962)

i already register launcher before onCreate

jb...@google.com <jb...@google.com> #5Jan 12, 2022 05:20PM

It did not throw before, and we made it so it does throw.

If you have properly registered and launched your launcher according to the docs and are not seeing the proper results, please file a new issue with a minimal sample project that reproduces what you are seeing.

wi...@gmail.com <wi...@gmail.com> #6Feb 2, 2022 01:54PM

Dsgdvdbvc. Xdbdr dktlutitirirevht bfenx vtturgfrgfvv. Bfrgd. CC. Dhffbv. Ben. Ddbfegdsfdsv. Cgnb. CD vrggfvbcbbcvbcccbcdvcdgfdfxvcx. Cdgdsgbdvcdcdsdssscxz. Dfhd g vcb vgncncgbbcbcdgccvvccbbcbcxcxxv cz. Vxbvd. Fryferrdgcc Gjrygh. Vgjgbv. Cbvfjgfjhfh vcmbcnvcgffhffhfgddgdbcf. Vfnfdjfdbvdnfrgffhfdbbcgb. Ggjgfjgdhbgbvcbgfhffgggf bgngfj bbbbbbTtythgtuytt h htigbcbcignvncbchckgjgjghvbvgv. Cbvnvnbbvcbvcbvbvcbvbvbvvcbvbbvnvbvbvv. Gjgfjgjggg Hgffjhfddb bgkhg

[Deleted User] <[Deleted User]> #7Mar 14, 2023 04:31AM

Comment has been deleted.

Message last modified on Mar 14, 2023 04:32AM

va...@gmail.com <va...@gmail.com> #8Mar 14, 2023 04:32AM

I am also using androidx.appcompat:appcompat:1.4.0 and got error
Caused by java.lang.IllegalStateException: Attempting to launch an unregistered ActivityResultLauncher with contract androidx.activity.result.contract.ActivityResultContracts$StartActivityForResult@7a32a4 and input Intent { cmp=com.aoki_style.www.aokimembers/com.locationvalue.ma2.view .activity.PrivacyActivity }. You must ensure the ActivityResultLauncher is registered before calling launch().
Please show me how to fix them.
I can't reproduce it on my device but I've checked for app crashes and they do appear.

an...@gmail.com <an...@gmail.com> #9Jun 5, 2024 11:01AM

Got this error with activity 1.8.2 if registering like in the documentation:

val getContent = registerForActivityResult(GetContent()) { uri: Uri? ->
    // Handle the returned Uri
}

override fun onCreate(savedInstanceState: Bundle?) {
    // ...

    val selectButton = findViewById<Button>(R.id.select_button)

    selectButton.setOnClickListener {
        // Pass in the mime type you want to let the user select
        // as the input
        getContent.launch("image/*")
    }
}

Every time I returned to the first activity, if I tried to launch the "getContent" again the app would crash. The only way I was able to get it to work was to registerForActivityResult in onCreate() like this:

lateinit var getContent: <ActivityResultLauncher<Contract...>>

override fun onCreate(savedInstanceState: Bundle?) {
    // ...

    getContent = registerForActivityResult(GetContent()) { uri: Uri? ->
        // Handle the returned Uri
    }

    val selectButton = findViewById<Button>(R.id.select_button)

    selectButton.setOnClickListener {
        // Pass in the mime type you want to let the user select
        // as the input
        getContent.launch("image/*")
    }
}

il...@google.com <il...@google.com> #10Jun 5, 2024 04:22PM

Re comment#9 - please file a new issue with a sample project that reproduces your issue.

lu...@gmail.com <lu...@gmail.com> #11Sep 20, 2024 02:14PM

We're currently hitting this issue in our WIP app. https://github.com/lineage-next/android_packages_apps_Twelve

We use our own wrapper around registerForActivityResult called PermissionsGatedCallback. We are able to hit the crash with the following:

Go to library
Pick any album
Pick any song
Back gesture (onto album fragment)
Back gesture (onto library fragment)
retry:
- Pick any album
- Back gesture (onto album fragment)
- Go to Artists (by swiping or navbar, doesn't matter)
- Pick any artist
- Back gesture (onto library fragment)
goto retry

I know the repro is rather tedious, but it's hard to repro even for us.

If done enough times you'll see java.lang.IllegalStateException: Attempting to launch an unregistered ActivityResultLauncher with contract androidx.activity.result.contract.ActivityResultContracts$RequestMultiplePermissions@d8b0d98 and input [Ljava.lang.String;@de949f1. You must ensure the ActivityResultLauncher is registered before calling launch().

Calling registerForActivityResult each time solves the issue as pointed earlier, as wrong as that can be. Also as crazy as that sounds making the contract launcher lazy (with re-init in case of null) and setting it to null on the lifecycle destroy event solves the issue as a whole.

To me that sounds possible only if somehow .launch is called when the fragment is destroyed, but the actual contract is still tied to the old fragment. Which sounds a lot scarier than the actual crash.

android_packages_apps_Twelve-lineage-22.0.zip

7.1 MB

Download

il...@google.com <il...@google.com> #12Sep 23, 2024 11:05PM

Re comment#11 - please file a new issue.