ActivityResultRegistry should throw when attempting to launch and unregistered launcher [192567522]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 1, 2021 05:28PM

Currently, when using the ActivityResultRegistry, you can call launch() on an ActivityResultLauncher that is not currently registered. This means that the targeted Activity can be launched, but there will not be any result meaning the API is not behaving as intended.

Instead of allowing developers to run into this issue, we should always throw from the registry when the launcher is not registered.

Comments

ap...@google.com <ap...@google.com> #2Jul 13, 2021 01:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

jb...@google.com <jb...@google.com> #3Jul 14, 2021 11:54PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

pv...@gmail.com <pv...@gmail.com> #4Jan 12, 2022 06:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

jb...@google.com <jb...@google.com> #5Jan 12, 2022 05:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

wi...@gmail.com <wi...@gmail.com> #6Feb 2, 2022 01:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

[Deleted User] <[Deleted User]> #7Mar 14, 2023 04:31AM

Comment has been deleted.

Message last modified on Mar 14, 2023 04:32AM

va...@gmail.com <va...@gmail.com> #8Mar 14, 2023 04:32AM

Project: platform/frameworks/support
Branch: androidx-main

commit a6ec8cc8df1fd6e8a4407ad15569d77914e9adb3
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 25 00:05:20 2023

Move OnBackPressedDispatcher extension to main artifact

As the main activity artifact is automatically included
whenever a developer depends on activity-ktx and these are
in an atomic library group, we can move the Kotlin
extension from activity-ktx to activity itself now that
the class itself has been moved to Kotlin.

Relnote: n/a
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I13482de2e25bd6e084f4b299dddd43b2bcf7a4c7

A activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
A activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401943

an...@gmail.com <an...@gmail.com> #9Jun 5, 2024 11:01AM

Project: platform/frameworks/support
Branch: androidx-main

commit d54d4417476c5ddc37251a910bdf37e9d278357e
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:57:45 2023

Replace usages of Consumer with a lambda

Now that OnBackPressedCallback and
OnBackPressedDispatcher are both written in Kotlin,
we can convert the callback between the two to be a
lambda method, rather than using a Consumer<Boolean>.

Test: tests still pass
BUG: 257291701
Change-Id: I0e2e4a3e7e9d6a3aeab1b8d2283fff321d45f44f

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401942

il...@google.com <il...@google.com> #10Jun 5, 2024 04:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 453e6f7acd7b7a1310487fc912f78c0fd2e72dd3
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:43:12 2023

Convert OnBackPressedDispatcher to Kotlin

Relnote: "`OnBackPressedDispatcher` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I18ac79d3cd20fc29159542b729935d3b8d2e4506

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401941

lu...@gmail.com <lu...@gmail.com> #11Sep 20, 2024 02:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57dd231f03ef3f5d107f7c9be9b0f5dd200d7ec4
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:01:48 2023

Rename OnBackPressedDispatcher.java to .kt

Test: n/a
BUG: 257291701
Change-Id: Id490de8b28b7d2a680c76c822f564fdadd5eb5f1

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401940

android_packages_apps_Twelve-lineage-22.0.zip

7.1 MB

Download

il...@google.com <il...@google.com> #12Sep 23, 2024 11:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76fcc8653339d275c9bfad10e4c68cd9c8ef0dfd
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 27 00:45:07 2023

Update wear module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iaf4f466f38a23c5522de019d38080b04c9f7b7ff

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt

https://android-review.googlesource.com/2405513