Missing Chip composable [192585545]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jul 1, 2021 10:29PM

With the release of wear-compose alpha, we can now create a Chip on smartwatches. However, this component is still missing from the main material library. Can we get it added for use on other devices too?

Comments

so...@google.com <so...@google.com> Jul 2, 2021 09:45AM

Assigned to co...@google.com.

co...@google.com <co...@google.com> #2Jul 2, 2021 01:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit 89251b3129e1895f169dd8df404a420c5785519c
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 09 17:35:30 2021

Support enabled parameter is slider and convert it to use SliderColor interface instead.

Slider has enabled/disabled states per spec and we need to support it for component to be stable.

Also, since we add even more color parameters, it is time to convert it to use SliderColors interface.

Fixes: 179793072
Test: added screenshot tests and a11y test for disabled
Change-Id: I6d56b992042f54b63daf4936ef6f6c27319b0498
Relnote: Slider now supports enabled/disabled state
Relnote: Slider custom colors are available now via SliderDefaults.colors() function

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/SliderSample.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SliderScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SliderTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt

https://android-review.googlesource.com/1581663

co...@google.com <co...@google.com> Dec 10, 2021 07:15PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #3Jan 13, 2022 10:09PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 626778ae40195514f47f5c5bb26fcc98007f67d0
Author: Connie Shi <connieshi@google.com>
Date: Wed Jan 12 20:54:27 2022

Add action chip scuba goldens.

Bug: 192585545, 182820312
Change-Id: I8c54105a874b8560d710ff82ef4490a2c7012206

A compose/material/material/actionChip_disabled_cuttlefish.png
A compose/material/material/actionChip_outlined_cuttlefish.png
A compose/material/material/actionChip_cuttlefish.png
A compose/material/material/actionChip_outlined_disabled_cuttlefish.png

https://android-review.googlesource.com/1947547

ap...@google.com <ap...@google.com> #4Jan 13, 2022 10:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8a96ec7c2119559fc3d7a63ad6b1851b626fcbf8
Author: Connie Shi <connieshi@google.com>
Date: Sun Nov 28 11:29:00 2021

Add support for action chip.

Bug: 192585545, 182820312
Test: Added unit, screenshot tests, demo and catalog sample.
Relnote: "Add support for action chip"
Change-Id: I07100d433428017c69701aa0dd6a1490e4ea3522

A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipTest.kt
A compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
A compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ChipDemos.kt
M compose/material/material/api/current.txt
M compose/material/material/api/1.1.0-beta05.txt
M compose/material/material/api/restricted_1.1.0-beta05.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipScreenshotTest.kt
M compose/material/material/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1904730

ap...@google.com <ap...@google.com> #5Jan 28, 2022 03:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 59c6b2733c7502308c6cbadb8790ff1d30fde536
Author: Connie Shi <connieshi@google.com>
Date: Thu Jan 27 17:05:53 2022

Adds single line scrollable chip group sample and recommend using Accompanist for reflow layout.

Bug: 192585545
Test: Manually ran catalog app.
Relnote: "Addes chip group sample"
Change-Id: I970808fe62083adaee55806e1707b4919d17ec3c

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/integration-tests/material-catalog/src/main/java/androidx/compose/material/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1952181

ap...@google.com <ap...@google.com> #6Feb 9, 2022 12:26PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit d2e9a8e75c5e4cb7f97993854ac5bd2314c648d7
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 17 15:03:02 2022

Add filter chip scuba goldens.

Bug: 192585545, 182821022
Change-Id: I9c1d0d98a6c6d7e735474084ea037377d4905e91

A compose/material/material/filterChip_disabled_selected_cuttlefish.png
A compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
A compose/material/material/filterChip_selected_cuttlefish.png
A compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
A compose/material/material/filterChip_notSelected_cuttlefish.png
A compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png

https://android-review.googlesource.com/1952176

ap...@google.com <ap...@google.com> #7Feb 9, 2022 12:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4526a45c72993f7f6ecaf04d8bf8a4b0826e1ff5
Author: Connie Shi <connieshi@google.com>
Date: Sat Jan 15 15:11:11 2022

Add filter chip screenshot tests.

Bug: 192585545, 182821022
Test: screenshot tests.
Relnote: N/A
Change-Id: I09d20ae90cb3edd019471e9e5af9db5140ef38d2

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipScreenshotTest.kt

https://android-review.googlesource.com/1950877

ap...@google.com <ap...@google.com> #8Feb 9, 2022 12:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6e3ec4f266c2da4b6acf3cc04a34f4b3437e85ad
Author: Connie Shi <connieshi@google.com>
Date: Fri Jan 14 13:08:39 2022

Add support for filter chips.

Bug: 192585545, 182821022
Test: Manually ran demo, adding tests in the next commit.
Relnote: `Add support for filter chips`
Change-Id: I39a6e25725a71191a2e78c2162419935d487ac59

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ChipDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1950876

sg...@google.com <sg...@google.com> Mar 1, 2022 07:59PM

Assigned to sg...@google.com.

sg...@google.com <sg...@google.com> Mar 26, 2022 01:18AM

Accepted by sg...@google.com.

am...@gmail.com <am...@gmail.com> #9Apr 2, 2022 12:07PM

The Chip documentation says that the onClick can be null

@param onClick called when the chip is clicked. If null, then this chip will be considered
read-only unless something else handles its input events and updates its state.

But the param is not nullable.

ap...@google.com <ap...@google.com> #10Apr 22, 2022 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit ede83c2b0d0fa77362acc732144ad97a1ae5095b
Author: Shalom Gibly <sgibly@google.com>
Date: Thu Apr 21 19:20:17 2022

Fixes a Material2 Chip doc error

Bug: 192585545
Test: N/A
Change-Id: Ie531b1479c305953ac2a4808d4260a0af4c1afe4

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt

https://android-review.googlesource.com/2072856

sg...@google.com <sg...@google.com> #11Apr 22, 2022 04:30PM

Marked as fixed.

Doc fixed.

Also, we now have Chips on the Material(2) and the Material3 libraries.

Closing this issue.