Missing Chip composable [192585545]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jul 1, 2021 10:29PM

With the release of wear-compose alpha, we can now create a Chip on smartwatches. However, this component is still missing from the main material library. Can we get it added for use on other devices too?

Comments

so...@google.com <so...@google.com> Jul 2, 2021 09:45AM

Assigned to co...@google.com.

co...@google.com <co...@google.com> #2Jul 2, 2021 01:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

co...@google.com <co...@google.com> Dec 10, 2021 07:15PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #3Jan 13, 2022 10:09PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 626778ae40195514f47f5c5bb26fcc98007f67d0
Author: Connie Shi <connieshi@google.com>
Date: Wed Jan 12 20:54:27 2022

Add action chip scuba goldens.

Bug: 192585545, 182820312
Change-Id: I8c54105a874b8560d710ff82ef4490a2c7012206

A compose/material/material/actionChip_disabled_cuttlefish.png
A compose/material/material/actionChip_outlined_cuttlefish.png
A compose/material/material/actionChip_cuttlefish.png
A compose/material/material/actionChip_outlined_disabled_cuttlefish.png

https://android-review.googlesource.com/1947547

ap...@google.com <ap...@google.com> #4Jan 13, 2022 10:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8a96ec7c2119559fc3d7a63ad6b1851b626fcbf8
Author: Connie Shi <connieshi@google.com>
Date: Sun Nov 28 11:29:00 2021

Add support for action chip.

Bug: 192585545, 182820312
Test: Added unit, screenshot tests, demo and catalog sample.
Relnote: "Add support for action chip"
Change-Id: I07100d433428017c69701aa0dd6a1490e4ea3522

A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipTest.kt
A compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
A compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ChipDemos.kt
M compose/material/material/api/current.txt
M compose/material/material/api/1.1.0-beta05.txt
M compose/material/material/api/restricted_1.1.0-beta05.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipScreenshotTest.kt
M compose/material/material/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1904730

ap...@google.com <ap...@google.com> #5Jan 28, 2022 03:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 59c6b2733c7502308c6cbadb8790ff1d30fde536
Author: Connie Shi <connieshi@google.com>
Date: Thu Jan 27 17:05:53 2022

Adds single line scrollable chip group sample and recommend using Accompanist for reflow layout.

Bug: 192585545
Test: Manually ran catalog app.
Relnote: "Addes chip group sample"
Change-Id: I970808fe62083adaee55806e1707b4919d17ec3c

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/integration-tests/material-catalog/src/main/java/androidx/compose/material/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1952181

ap...@google.com <ap...@google.com> #6Feb 9, 2022 12:26PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit d2e9a8e75c5e4cb7f97993854ac5bd2314c648d7
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 17 15:03:02 2022

Add filter chip scuba goldens.

Bug: 192585545, 182821022
Change-Id: I9c1d0d98a6c6d7e735474084ea037377d4905e91

A compose/material/material/filterChip_disabled_selected_cuttlefish.png
A compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
A compose/material/material/filterChip_selected_cuttlefish.png
A compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
A compose/material/material/filterChip_notSelected_cuttlefish.png
A compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png

https://android-review.googlesource.com/1952176

ap...@google.com <ap...@google.com> #7Feb 9, 2022 12:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4526a45c72993f7f6ecaf04d8bf8a4b0826e1ff5
Author: Connie Shi <connieshi@google.com>
Date: Sat Jan 15 15:11:11 2022

Add filter chip screenshot tests.

Bug: 192585545, 182821022
Test: screenshot tests.
Relnote: N/A
Change-Id: I09d20ae90cb3edd019471e9e5af9db5140ef38d2

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipScreenshotTest.kt

https://android-review.googlesource.com/1950877

ap...@google.com <ap...@google.com> #8Feb 9, 2022 12:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6e3ec4f266c2da4b6acf3cc04a34f4b3437e85ad
Author: Connie Shi <connieshi@google.com>
Date: Fri Jan 14 13:08:39 2022

Add support for filter chips.

Bug: 192585545, 182821022
Test: Manually ran demo, adding tests in the next commit.
Relnote: `Add support for filter chips`
Change-Id: I39a6e25725a71191a2e78c2162419935d487ac59

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ChipDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1950876

sg...@google.com <sg...@google.com> Mar 1, 2022 07:59PM

Assigned to sg...@google.com.

sg...@google.com <sg...@google.com> Mar 26, 2022 01:18AM

Accepted by sg...@google.com.

am...@gmail.com <am...@gmail.com> #9Apr 2, 2022 12:07PM

The Chip documentation says that the onClick can be null

@param onClick called when the chip is clicked. If null, then this chip will be considered
read-only unless something else handles its input events and updates its state.

But the param is not nullable.

ap...@google.com <ap...@google.com> #10Apr 22, 2022 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit ede83c2b0d0fa77362acc732144ad97a1ae5095b
Author: Shalom Gibly <sgibly@google.com>
Date: Thu Apr 21 19:20:17 2022

Fixes a Material2 Chip doc error

Bug: 192585545
Test: N/A
Change-Id: Ie531b1479c305953ac2a4808d4260a0af4c1afe4

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt

https://android-review.googlesource.com/2072856

sg...@google.com <sg...@google.com> #11Apr 22, 2022 04:30PM

Marked as fixed.

Doc fixed.

Also, we now have Chips on the Material(2) and the Material3 libraries.

Closing this issue.