Status Update
Comments
so...@google.com <so...@google.com>
co...@google.com <co...@google.com>
ap...@google.com <ap...@google.com> #3
Thanks for the report!
ap...@google.com <ap...@google.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
ap...@google.com <ap...@google.com> #5
ap...@google.com <ap...@google.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit 4526a45c72993f7f6ecaf04d8bf8a4b0826e1ff5
Author: Connie Shi <connieshi@google.com>
Date: Sat Jan 15 15:11:11 2022
Add filter chip screenshot tests.
Bug: 192585545, 182821022
Test: screenshot tests.
Relnote: N/A
Change-Id: I09d20ae90cb3edd019471e9e5af9db5140ef38d2
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ChipScreenshotTest.kt
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit 6e3ec4f266c2da4b6acf3cc04a34f4b3437e85ad
Author: Connie Shi <connieshi@google.com>
Date: Fri Jan 14 13:08:39 2022
Add support for filter chips.
Bug: 192585545, 182821022
Test: Manually ran demo, adding tests in the next commit.
Relnote: `Add support for filter chips`
Change-Id: I39a6e25725a71191a2e78c2162419935d487ac59
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ChipDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/api/public_plus_experimental_current.txt
sg...@google.com <sg...@google.com>
sg...@google.com <sg...@google.com>
am...@gmail.com <am...@gmail.com> #9
The Chip documentation says that the onClick can be null
@param onClick called when the chip is clicked. If null, then this chip will be considered
read-only unless something else handles its input events and updates its state.
But the param is not nullable.
ap...@google.com <ap...@google.com> #10
Branch: androidx-main
commit ede83c2b0d0fa77362acc732144ad97a1ae5095b
Author: Shalom Gibly <sgibly@google.com>
Date: Thu Apr 21 19:20:17 2022
Fixes a Material2 Chip doc error
Bug: 192585545
Test: N/A
Change-Id: Ie531b1479c305953ac2a4808d4260a0af4c1afe4
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
sg...@google.com <sg...@google.com> #11
Doc fixed.
Also, we now have Chips on the Material(2) and the Material3 libraries.
Closing this issue.
Description
With the release of
wear-compose
alpha, we can now create aChip
on smartwatches. However, this component is still missing from the mainmaterial
library. Can we get it added for use on other devices too?