EditText: inputType does not take specified digits into account [193047889]

Duplicate

of 207119921

Bug

adexe s nau

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

Jul 8, 2021 01:33PM

Component used: AppCompat
Version used: 1.4.0-alpha03
Devices/Android versions reproduced on: Pixel 3a XL

I use code below to display EditText in which user can type IP-address

Upon further tests I discovered that android:inputType ignores android:digits

<EditText
...
android:inputType="number"
android:digits="01234"
...
/>

For all previous releases (including 1.4.0-alpha02 and below) I got numeric keyboard, which allowed me to enter only 1, 2, 3, or 4.

In release 1.4.0-alpha03 I can type any number (0-9)

InputTypeBug.zip

19 MB

Download

Comments

dm...@gmail.com <dm...@gmail.com> #2Jul 8, 2021 01:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020

Rename BottomNavigationItem parameters

text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state

Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1373097

al...@google.com <al...@google.com> Jul 8, 2021 02:13PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #3Jul 13, 2021 07:49PM

Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).

se...@google.com <se...@google.com> #4Jul 13, 2021 09:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020

Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1423472

dm...@gmail.com <dm...@gmail.com> #5Jul 13, 2021 09:05PM

Thanks) glad I helped

ap...@google.com <ap...@google.com> #6Jul 13, 2021 09:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit b19124e0241b9d63352714c6bc7dbfbcab962058
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Jul 13 13:59:33 2021

Retain android:digits in AppCompatEditText

Previously, digits specified with android:digits were replaced with
[0,1,2,3,4,5,6,7,8,9] during the emoji initalizer.

This bug was introduced in appcompat 1.4.0-alpha03.

Relnote: "Correctly retain android:digits in AppCompatEditText, this
fixes

bug 193047889

introduced in appcompat 1.4.0-alpha03."
Test: New test, and manual testing
Bug:

b/193047889

Change-Id: I4b4fc1ccc429724743cab8a965d7e3adec356fd1

M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java

https://android-review.googlesource.com/1765245

se...@google.com <se...@google.com> Jul 13, 2021 10:42PM

Marked as fixed.

si...@gmail.com <si...@gmail.com> #7Dec 5, 2021 08:30AM

Issue still persists in appcompat 1.4.0 and it works fine when I reverted the version to 1.3.1. Tested in the following devices:
Phones : Redmi 7a(Android 10), Poco F1(Android 10) and Samsung Galaxy A71(Android 11)
Emulators : Nexus 5X API 30

InputType Issue.zip

105 KB

Download

mi...@gmail.com <mi...@gmail.com> #8Dec 30, 2021 07:36AM

This issue is still present in appcompat:1.4.0 any solution?

se...@google.com <se...@google.com> #9Jan 4, 2022 06:59PM

Status: Duplicate of

207119921

This will be fixed in the next bugfix release.