Status Update
Comments
dm...@gmail.com <dm...@gmail.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
al...@google.com <al...@google.com>
se...@google.com <se...@google.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
se...@google.com <se...@google.com> #4
Yep, confirmed this was introduced in 1.4.0-alpha03, and only exists in that version.
Patch coming shortly.
Thank you again for the report it was incredibly helpful!
Patch coming shortly.
Thank you again for the report it was incredibly helpful!
dm...@gmail.com <dm...@gmail.com> #5
Thanks) glad I helped
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit b19124e0241b9d63352714c6bc7dbfbcab962058
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Jul 13 13:59:33 2021
Retain android:digits in AppCompatEditText
Previously, digits specified with android:digits were replaced with
[0,1,2,3,4,5,6,7,8,9] during the emoji initalizer.
This bug was introduced in appcompat 1.4.0-alpha03.
Relnote: "Correctly retain android:digits in AppCompatEditText, this
fixes bug 193047889 introduced in appcompat 1.4.0-alpha03."
Test: New test, and manual testing
Bug: b/193047889
Change-Id: I4b4fc1ccc429724743cab8a965d7e3adec356fd1
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
https://android-review.googlesource.com/1765245
Branch: androidx-main
commit b19124e0241b9d63352714c6bc7dbfbcab962058
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Jul 13 13:59:33 2021
Retain android:digits in AppCompatEditText
Previously, digits specified with android:digits were replaced with
[0,1,2,3,4,5,6,7,8,9] during the emoji initalizer.
This bug was introduced in appcompat 1.4.0-alpha03.
Relnote: "Correctly retain android:digits in AppCompatEditText, this
fixes
Test: New test, and manual testing
Bug:
Change-Id: I4b4fc1ccc429724743cab8a965d7e3adec356fd1
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
se...@google.com <se...@google.com>
si...@gmail.com <si...@gmail.com> #7
Issue still persists in appcompat 1.4.0 and it works fine when I reverted the version to 1.3.1. Tested in the following devices:
Phones : Redmi 7a(Android 10), Poco F1(Android 10) and Samsung Galaxy A71(Android 11)
Emulators : Nexus 5X API 30
Phones : Redmi 7a(Android 10), Poco F1(Android 10) and Samsung Galaxy A71(Android 11)
Emulators : Nexus 5X API 30
mi...@gmail.com <mi...@gmail.com> #8
This issue is still present in appcompat:1.4.0 any solution?
Description
Version used: 1.4.0-alpha03
Devices/Android versions reproduced on: Pixel 3a XL
I use code below to display EditText in which user can type IP-address
Upon further tests I discovered that android:inputType ignores android:digits
<EditText
...
android:inputType="number"
android:digits="01234"
...
/>
For all previous releases (including 1.4.0-alpha02 and below) I got numeric keyboard, which allowed me to enter only 1, 2, 3, or 4.
In release 1.4.0-alpha03 I can type any number (0-9)