Baseline file is currently an Input and an Output of the Lint tasks [193244776]

Fixed

Bug

Status Update

No update yet.

Description

st...@google.com

created issue #1

Jul 9, 2021 05:40PM

AndroidLintTask lists the lint baseline file (e.g. lint-baseline.xml) as an @InputFiles property, but the file is also functioning as an @Output of the task, since Lint, as documented here, re-generates the baseline file if one doesn't exist.

This isn't good practice in Gradle, and leads to some odd behavior.

For instance, if you:

run gradlew app:lint -Dlint.baselines.continue=true, generating a new baseline file
immediately delete the new baseline file
re-run gradlew app:lint -Dlint.baselines.continue=true

The baseline file is not re-created, since Gradle observes the same "before" state for both invocations and marks the task as Up-To-Date (Gradle doesn't include the file in the "after" snapshot for the task because the file isn't marked as an @Output). A fix/workaround is pending for this particular issue, but there may be other issues inherent to this non-idiomatic use of the Gradle API.

This comment proposes a fix in AGP for the broader issue.

Comments

xa...@google.com <xa...@google.com> #2Jul 1, 2022 07:50PM

Okay. I tried a bunch of agp+android studio versions

The last working version was classpath("com.android.tools.build:gradle:7.4.0-alpha06")

once I moved to

classpath("com.android.tools.build:gradle:7.4.0-alpha07") then things start breaking on firebase app dist.

au...@google.com <au...@google.com> #3Sep 16, 2022 07:55PM

Scott, assigning to you as it seem to complain the zip is not aligned while packaging which is very puzzling considering the steps...

sp...@google.com <sp...@google.com> #4Sep 16, 2022 07:57PM

OP, when you build the APK with AGP, are you doing any post-processing on the APK and/or do you have any custom tasks that are modifying the APK?

Can you try to verify the alignment of your APK with zipalign locally (zipalign is included in build-tools):

zipalign -c -v 4 foo.apk

sp...@google.com <sp...@google.com> #5Nov 12, 2022 12:27AM

Not doing any post processing. No custom tasks. I will try to verify alignment now. Give me a sec.

Message last modified on Nov 21, 2022 07:31PM

sp...@google.com <sp...@google.com> #6Nov 22, 2022 07:58PM

Marked as fixed.

Scenario 1:

built my apk with agp alpha09, but didn't update firebase (bom = 30.2.0)
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification succesful"

Scenario 2:

built my apk with agp alpha09, but I DID update firebase (bom = 30.3.1)
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification FAILED"

Issue 193244776