Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 25369f983e26d758a8a027c84b21f20026637181
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 12 14:05:36 2021
Update JankCollectionHelper to support S gfxinfo
Fixes: 193260119
Relnote: Fixes FrameTimingMetric to work on Android S beta
Test: ./gradlew bench:integration-tests:macrobenchmark:connectedAndroidTest -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark # On R + S
Still manually cherry-picking changes, as the platform copy of the
file triggers many lint warnings in AndroidX build.
Change-Id: Ib60ccf09fb2fa09f128374140c3657015626dd2c
M benchmark/macro/src/main/java/androidx/benchmark/macro/JankCollectionHelper.java
M benchmark/macro/src/main/java/androidx/benchmark/macro/Metric.kt
https://android-review.googlesource.com/1763870
Branch: androidx-main
commit 25369f983e26d758a8a027c84b21f20026637181
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 12 14:05:36 2021
Update JankCollectionHelper to support S gfxinfo
Fixes: 193260119
Relnote: Fixes FrameTimingMetric to work on Android S beta
Test: ./gradlew bench:integration-tests:macrobenchmark:connectedAndroidTest -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark # On R + S
Still manually cherry-picking changes, as the platform copy of the
file triggers many lint warnings in AndroidX build.
Change-Id: Ib60ccf09fb2fa09f128374140c3657015626dd2c
M benchmark/macro/src/main/java/androidx/benchmark/macro/JankCollectionHelper.java
M benchmark/macro/src/main/java/androidx/benchmark/macro/Metric.kt
Description
Tests fail with:
com.example.macrobenchmark.FrameTimingBenchmark > start[Pixel 4 XL - 12] FAILED java.lang.RuntimeException: Encountered exception getting gfxinfo. at androidx.benchmark.macro.JankCollectionHelper.getMetrics(JankCollectionHelper.java:227)